Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watch document with option when watch a database on reactive mongo client #28828

Merged
merged 1 commit into from Oct 26, 2022
Merged

Fix watch document with option when watch a database on reactive mongo client #28828

merged 1 commit into from Oct 26, 2022

Conversation

ruget
Copy link
Contributor

@ruget ruget commented Oct 25, 2022 •
edited by geoand

Fixes: #22827

@ruget ruget mentioned this pull request Oct 25, 2022
Closed
@geoand geoand changed the title 22827 Fix watch document with option when watch a database on reactive client Fix watch document with option when watch a database on reactive client Oct 26, 2022
@geoand geoand changed the title Fix watch document with option when watch a database on reactive client Fix watch document with option when watch a database on reactive mongo client Oct 26, 2022
@geoand
Copy link
Contributor

geoand commented Oct 26, 2022

This seems reasonable to me. @cescoffier WDYT?

cescoffier
cescoffier approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Definitely some mistakes when I implemented that!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2022
@gsmet gsmet merged commit 6b60931 into quarkusio:main Oct 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 26, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2022

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 26, 2022
@ruget ruget deleted the 28827 branch October 26, 2022 07:35
@gsmet gsmet modified the milestones: 2.14.0.CR1, 2.13.4.Final Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/mongodb kind/bugfix
Projects
None yet
Milestone
2.13.4.Final
Development

Successfully merging this pull request may close these issues.

OIDC-Client: Response status 0 and null entity when OIDC client auth is failing for Rest-Client-Reactive
4 participants
@ruget @geoand @cescoffier @gsmet