Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use major.minor part of GraalVM version in documentation #28843

Merged
merged 4 commits into from Oct 26, 2022

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 26, 2022

Users should always be encouraged to use the latest release of a feature release, i.e., prefer 22.3.1 over 22.3.0.

Micro releases (called CPU releases in GraalVM) should not break compatibility, instead they should only bring bug fixes. As a result they should be considered safe to use.

This change also enables referencing the version specific graalvm docs as discussed in
https://github.com/quarkusio/quarkus/pull/28628/files#r996786908

Additionally:

  • Java 8 in JVM mode is no longer supported and the default native builder images are now Java 17 based.
  • The minimum supported GraalVM version is now 22.2 so any reference to earlier versions is obsolete.
  • The PR replaces links to the github repository's master branch with links to the published documentation for the corresponding GraalVM version

@zakkak zakkak requested review from galderz and gsmet October 26, 2022 09:04
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation labels Oct 26, 2022
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Oct 26, 2022
Quarkus Documentation automation moved this from To do to Reviewer approved Oct 26, 2022
@gsmet
Copy link
Member

gsmet commented Oct 26, 2022

@zakkak makes perfect sense, thanks. Would you be kind enough to rebase @galderz 's PR once this is in? I bet they are going to conflict.

@zakkak
Copy link
Contributor Author

zakkak commented Oct 26, 2022

@zakkak makes perfect sense, thanks. Would you be kind enough to rebase @galderz 's PR once this is in? I bet they are going to conflict.

Sure, I can take care of this.

Can you think of any way to avoid running all the jobs when updating a documentation-related property in the pom files?

@gsmet
Copy link
Member

gsmet commented Oct 26, 2022

We could move the properties to the docs pom but we need to make sure we don't forget about them.

@gsmet
Copy link
Member

gsmet commented Oct 26, 2022

I think they were originally put there because we had other GraalVM version properties here but we moved them to Java code.

@zakkak
Copy link
Contributor Author

zakkak commented Oct 26, 2022

We could move the properties to the docs pom but we need to make sure we don't forget about them.

Well even now the properties defining the GraalVM version are located in different properties so I think it won't make much difference:

$ rg '<graal-sdk.version'  
bom/application/pom.xml
83:        <graal-sdk.version>22.2.0</graal-sdk.version>

build-parent/pom.xml
43:        <graal-sdk.version-for-documentation>22.2</graal-sdk.version-for-documentation>

independent-projects/bootstrap/pom.xml
65:        <graal-sdk.version>22.2.0</graal-sdk.version>

I think they were originally put there because we had other GraalVM version properties here but we moved them to Java code.

OK, I am moving them in the docs pom file then.

Users should always be encouraged to use the latest release of a feature
release, i.e., prefer 22.3.1 over 22.3.0.

Micro releases (called CPU releases in GraalVM) should not break
compatibility, instead they should only bring bug fixes. As a result
they should be considered safe to use.

This change also enables referecing the version specific graalvm docs as
discussed in
https://github.com/quarkusio/quarkus/pull/28628/files#r996786908
Java 8 in JVM mode is no longer supported and the default native builder
images are now Java 17 based.

Furthermore, the minimum supported GraalVM version is now 22.2 so any
reference to earlier versions is obsolete.
* Use major.minor version of GraalVM to pin links to the corresponding
documentation
* Replace links to the github repository's master branch with links to
the published documentation for the corresponding GraalVM version
… pom

The properties defining the GraalVM version are already located in
different files. Moving these properties to docs/pom.xml avoids running
all the CI jobs when altering them (which is the right thing to do as
they only affect the documentation).
@zakkak zakkak force-pushed the 2022-10-26-docs-version-majorminor branch from f4362c1 to 080dc77 Compare October 26, 2022 11:43
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2022

Failing Jobs - Building 080dc77

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/opentelemetry/deployment 
! Skipped: integration-tests/micrometer-prometheus integration-tests/opentelemetry integration-tests/opentelemetry-grpc and 5 more

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.instrumentation.RestClientOpenTelemetryTest.client line 65 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <SERVER> but was: <CLIENT>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 341 more

📦 extensions/vertx/deployment

io.quarkus.vertx.DuplicatedContextTest.testThatBlockingEventConsumersAreCalledOnDuplicatedContext - More details - Source on GitHub

(RECIPIENT_FAILURE,8185) java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedSocketException: Connection reset by peer: localhost/127.0.0.1:8082
	at io.vertx.core.eventbus.Message.fail(Message.java:141)
	at io.quarkus.vertx.runtime.VertxRecorder$3$1$1.handle(VertxRecorder.java:122)

@gsmet gsmet merged commit aba7d40 into quarkusio:main Oct 26, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Oct 26, 2022
@zakkak zakkak deleted the 2022-10-26-docs-version-majorminor branch October 26, 2022 17:06
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.0.Final Oct 28, 2022
@gsmet gsmet removed this from the 2.14.0.Final milestone Nov 2, 2022
@gsmet gsmet added this to the 2.13.4.Final milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation
Development

Successfully merging this pull request may close these issues.

None yet

2 participants