Fix compatibility with Redis 5 #28854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output format of a few commands has changed between Redis 5 and 6. This PR allows us to verify the compatibility with Redis 5, 6, and 7. Note that it's the best effort, and we do not intend full compatibility with Redis 5, only the main use cases. Typically, Redis Stack is only supported with Redis 7.
machi1990
approved these changes
Oct 27, 2022
|
I assume this needs to be backported to |
|
If we want this for 2.13, we will need a specific backport PR as there are too many conflicts. They doesn't look hard to fix but I would prefer if someone familiar with the extension did it. |
|
No, it's a best-effort thing. Initially we targetted Redis 6 and 7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output format of a few commands has changed between Redis 5 and 6.
This PR allows us to verify the compatibility with Redis 5, 6, and 7.
Note that it's the best effort, and we do not intend full compatibility with Redis 5, only the main use cases. Typically, Redis Stack is only supported with Redis 7.
Fix #28837