Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get image reference registry from build item to avoid log warnings #28945

Merged
merged 1 commit into from Oct 31, 2022
Merged

Get image reference registry from build item to avoid log warnings #28945

merged 1 commit into from Oct 31, 2022

Conversation

Sgitario
Copy link
Contributor

Fix #28936

@Sgitario Sgitario requested a review from iocanel October 31, 2022 10:31
iocanel
iocanel approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Oct 31, 2022
@gsmet
Copy link
Member

gsmet commented Oct 31, 2022

@Sgitario is this something that needs a backport to 2.13 or it's a new feature?

@Sgitario
Copy link
Contributor Author

@Sgitario is this something that needs a backport to 2.13 or it's a new feature?

This fixes a very minor issue (logging a warning). I would not backport it to 2.13,

@geoand geoand merged commit 6edbe76 into quarkusio:main Oct 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Oct 31, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 31, 2022
@Sgitario Sgitario deleted the 28936 branch October 31, 2022 13:14
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.0.Final Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
kind/bugfix
Projects
None yet
Milestone
2.14.0.Final
Development

Successfully merging this pull request may close these issues.

Wrong warnings when pushing images using JIB, Docker or BuildPack
4 participants
@Sgitario @gsmet @iocanel @geoand