Some proofreading for the Dev Services for Kubernetes doc #29014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Nov 3, 2022
|
|
||
| In dev mode and when running tests, xref:kubernetes-dev-services.adoc[Dev Services for Kubernetes] automatically starts a Kubernetes API server. | ||
| In dev mode and when running tests, xref:kubernetes-dev-services.adoc[Dev Services for Kubernetes] automatically start a Kubernetes API server. |
There was a problem hiding this comment.
I am not totally sure about this one. I understand why you made the change, but the way I read it is that Dev Services for Kubernetes is a single entity, therefore starts is appropriate. The same goes for the other changes made later on.
There was a problem hiding this comment.
Yeah I must admit I hesitated a bit about that one. So if you also do, let's keep it as is. I'll adjust the PR.
There was a problem hiding this comment.
@geoand it should be ready to go now.
gsmet
force-pushed
the
proofread-kubernetes-devservices
branch
from
ad7878b
to
d779b5f
Compare
gsmet
force-pushed
the
proofread-kubernetes-devservices
branch
from
d779b5f
to
55ec341
Compare
This comment has been minimized.
This comment has been minimized.
geoand
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.