Update to graalvm and mandrel 22.3.0 - 2.13 #29028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cescoffier
commented
Nov 3, 2022
•
cescoffier
commented
- Update to GraalVM and Mandrel 22.3.0 images
- Use the GraalVM 22.3 AlwaysInline annotation
quarkus-bot
bot
added
area/core
area/dependencies
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
cescoffier
changed the title
This comment has been minimized.
This comment has been minimized.
zakkak
previously requested changes
Nov 3, 2022
There was a problem hiding this comment.
LGTM, other than the documentation issue.
Thanks @cescoffier
cescoffier
force-pushed
the
update-to-graalvm-and-mandrel-22.3.0
branch
from
8a6fa2b
to
181ecc3
Compare
gsmet
changed the title
|
@ppalaga here is your 2.13 branch with GraalVM 22.3 ^ |
|
Don't worry about the quickstarts compilation, that's normal. |
Cherry-Pick of 4eecb96
This annotation has moved to a new package and we need to use the 22.3 version to make sure our code compiles. As for using 22.2, it still works but the annotation is ignored, which looks OK as the annotation is not used in places where it is strictly necessary. If people use the recommended GraalVM version, everything will be fine. If not, things will mostly work anyway. (cherry picked from commit 6c5700f)
cescoffier
force-pushed
the
update-to-graalvm-and-mandrel-22.3.0
branch
from
181ecc3
to
c087f36
Compare
gsmet
approved these changes
Nov 3, 2022
zakkak
approved these changes
Nov 3, 2022
Failing Jobs - Building c087f36
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖ |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Nov 16, 2022
The reasoning behind this short-circuiting is to clean up the code-path used when obtaining a Validator object programmatically. This ultimately makes it possible for code that obtains the Validator object programmatically to work in native mode. Fixes: quarkusio#29028
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Nov 21, 2022
The reasoning behind this short-circuiting is to clean up the code-path used when obtaining a Validator object programmatically. This ultimately makes it possible for code that obtains the Validator object programmatically to work in native mode. Fixes: quarkusio#29028 (cherry picked from commit d41f300)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.