Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent https://bugs.openjdk.org/browse/JDK-8180450 for cache code #29044

Merged
merged 1 commit into from Nov 4, 2022
Merged

Prevent https://bugs.openjdk.org/browse/JDK-8180450 for cache code #29044

merged 1 commit into from Nov 4, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 3, 2022

No description provided.

@geoand geoand requested a review from Ladicek November 3, 2022 16:10
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cache labels Nov 3, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
Ladicek
Ladicek approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though maybe @gwenneg wants to take a look as well?

Also, this indeed leads to non-idiomatic code. I believe you have benchmark numbers showing an improvement, could you share them here for justification?

@geoand
Copy link
Contributor Author

geoand commented Nov 4, 2022 •
edited

Sure yeah.

When I tested the change made here vs the code in main for the application mentioned in #28795, I observed that an average request time of 40ms was sustainable for 670k req/sec vs 650k req/sec.
That's not a very large improvement, but it's not neglibile either.

I should also mention that the tests where run on a AMD Ryzen 5950X CPU and an Ubuntu 20.04 OS.

@gwenneg
Copy link
Member

gwenneg commented Nov 4, 2022 •
edited

Are the changes in the cache extension temporary or will they remain after the bug in the JDK has been fixed?

@geoand
Copy link
Contributor Author

geoand commented Nov 4, 2022

Don't hold your breath for the JDK issue to be fixed 😉

If it ever does get fixed, then yeah, this along with a bunch of other fixes we have made can be reverted.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2022

Failing Jobs - Building 4334c57

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand geoand merged commit b58b24f into quarkusio:main Nov 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 4, 2022
@geoand geoand deleted the cache-type-polution branch November 4, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba left review comments

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/cache
Projects
None yet
Milestone
2.15.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@geoand @gwenneg @Ladicek @mkouba