Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - try to avoid type/cache pollution in the EvaluatorImpl #29045

Merged
merged 1 commit into from Nov 4, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 3, 2022

qute-microbenchmarks

@mkouba mkouba added the area/qute The template engine label Nov 3, 2022
@geoand
Copy link
Contributor

geoand commented Nov 3, 2022

@mkouba just for the interest of completeness, it would be nice to link to the benchmark you used and the specs of the machine it was run on in the description.

@mkouba
Copy link
Contributor Author

mkouba commented Nov 3, 2022

@mkouba just for the interest of completeness, it would be nice to link to the benchmark you used and the specs of the machine it was run on in the description.

For sure. I always use https://github.com/mkouba/qute-benchmarks/ to test qute and forgot to add the link here ;-).

And the machine was a dedicated box with Ubuntu Server 20.04.4 LTS, Linux 5.4.0-125-generic, openjdk 11.0.11, Intel i5-6260U with 4 cores and 16GB RAM.

@mkouba mkouba removed the area/cache label Nov 3, 2022
@geoand
Copy link
Contributor

geoand commented Nov 3, 2022

4 cores

If the benchmark is run on a machine with more cores, there should be an even bigger speedup :)

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 3, 2022

Failing Jobs - Building 3573ab9

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/logging-gelf 

📦 integration-tests/logging-gelf

io.quarkus.logging.gelf.it.GelfLogHandlerTest.test line 32 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.logging.gelf.it.GelfLogHandlerTest expected: not <null> within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@geoand geoand merged commit ca41040 into quarkusio:main Nov 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants