Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2 embedded: disable support for compiling javascript/groovy triggers #29062

Merged
merged 1 commit into from Nov 4, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Nov 4, 2022

Not including aa test as I'm not sure how to trigger it - but this should fix a problem in the ecosystem CI:

@Sanne
Copy link
Member Author

Sanne commented Nov 4, 2022

cc/ @beikov

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2022

Failing Jobs - Building add0d39

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/opentelemetry/deployment 
! Skipped: integration-tests/micrometer-prometheus integration-tests/opentelemetry-vertx 

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.instrumentation.RestClientOpenTelemetryTest.urlWithoutAuthentication line 114 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CLIENT> but was: <SERVER>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@Sanne
Copy link
Member Author

Sanne commented Nov 4, 2022

Thanks @geoand !

I'll wait to merge for @beikov 's opinion as there might be more to it.

@geoand
Copy link
Contributor

geoand commented Nov 4, 2022

Sure thing, makes sense

@beikov
Copy link
Contributor

beikov commented Nov 4, 2022

Ok, my local tests showed that this fixes the problem

@Sanne Sanne merged commit e1875aa into quarkusio:main Nov 4, 2022
@Sanne Sanne deleted the H2Compiler branch November 4, 2022 16:35
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 4, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants