Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Mandrel 22.3 does not provide a -java11 image anymore #29087

Merged
merged 1 commit into from Nov 10, 2022

Conversation

cescoffier
Copy link
Member

No description provided.

@cescoffier
Copy link
Member Author

Fix graalvm/mandrel#456.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few minor suggestions.

docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/native-reference.adoc Outdated Show resolved Hide resolved
Quarkus Documentation automation moved this from To do to Review pending Nov 7, 2022
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @cescoffier , I have added a couple of recommendations for your consideration.

I think at least the formatting ones (along with @gsmet 's suggestions) should be integrated.

docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/native-reference.adoc Outdated Show resolved Hide resolved
@gsmet
Copy link
Member

gsmet commented Nov 9, 2022

@cescoffier could you have a look at our suggestions? Thanks.

@cescoffier
Copy link
Member Author

@gsmet done.

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added another suggestion you might want to consider.

docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied @zakkak 's suggestion and squashed. It's ready to go.

Quarkus Documentation automation moved this from Review pending to Reviewer approved Nov 10, 2022
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 10, 2022
@gsmet gsmet merged commit 9108cfa into quarkusio:main Nov 10, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 10, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 10, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 10, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 10, 2022
@cescoffier cescoffier deleted the mandrel-no-java11 branch November 14, 2022 12:24
@gsmet gsmet removed this from the 2.14.1.Final milestone Dec 12, 2022
@gsmet gsmet added this to the 2.13.6.Final milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document the fact that there are no more -java11 in 22.3
3 participants