Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix Typo in RabbitMQ Channel Config #29302

Merged
merged 1 commit into from Nov 16, 2022
Merged

Docs: Fix Typo in RabbitMQ Channel Config #29302

merged 1 commit into from Nov 16, 2022

Conversation

zigad
Copy link
Contributor

@zigad zigad commented Nov 16, 2022

This PR will fix typo made in recent change to Rabbit MQ Connection Documentation #29267.
There are wrong ' so I replaced them with correct ones.

Please squash and merge after review

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Nov 16, 2022
@zigad zigad mentioned this pull request Nov 16, 2022
Merged
Quarkus Documentation automation moved this from To do to Reviewer approved Nov 16, 2022
gsmet
gsmet requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the commits on your side and force-push?

We are using merge commits so we will have to do it manually anyway.

Quarkus Documentation automation moved this from Reviewer approved to Review pending Nov 16, 2022
@zigad
Copy link
Contributor Author

zigad commented Nov 16, 2022

Could you squash the commits on your side and force-push?

We are using merge commits so we will have to do it manually anyway.

Done 👍🏻

Quarkus Documentation automation moved this from Review pending to Reviewer approved Nov 16, 2022
@gsmet gsmet merged commit 18e20d6 into quarkusio:main Nov 16, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 16, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangunalp ozangunalp ozangunalp approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Done
Milestone
2.14.2.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zigad @ozangunalp @gsmet