Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce way to customize ServerHandler with runtime config #29352

Merged
merged 1 commit into from Nov 18, 2022
Merged

Introduce way to customize ServerHandler with runtime config #29352

merged 1 commit into from Nov 18, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 18, 2022 •
edited

Essentially extensions can now use the HandlerConfigurationProviderBuildItem to register the configuration class they work for and how the value can be obtained

This is needed in order to address the use case in #29280

@geoand
Introduce way to customize ServerHandler with runtime config
6eecb91 
Essentially extensions can now use the HandlerConfigurationProviderBuildItem
to register the configuration class they work for and how the value can
be obtained
@geoand geoand mentioned this pull request Nov 18, 2022
Merged
@sberyozkin sberyozkin self-requested a review November 18, 2022 13:45
sberyozkin
sberyozkin approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful enhancement IMHO, thanks Georgios

@geoand
Copy link
Contributor Author

geoand commented Nov 18, 2022

You are welcome!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Nov 18, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 18, 2022

Failing Jobs - Building 6eecb91

Status Name Step Failures Logs Raw logs
✖ Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/reactive-messaging-kafka

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorIT.testPets - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Unable to successfully launch process '17943'. Exit code is: '1'.
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:337)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:110)

@geoand geoand merged commit c0e0cbb into quarkusio:main Nov 18, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 18, 2022
@geoand geoand deleted the rr-runtime-handlers branch November 21, 2022 06:10
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/resteasy-reactive
Projects
None yet
Milestone
2.14.2.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geoand @sberyozkin @gsmet