Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS port configuration in the HTTP reference guide #29356

Merged
merged 1 commit into from Nov 21, 2022

Conversation

loicmathieu
Copy link
Contributor

There is no mention of the value of the HTTPS port in the HTTP reference guide, nor the way to configure it.

This PR add a small section for this issue.

gsmet
gsmet previously requested changes Nov 18, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some suggestions.

docs/src/main/asciidoc/http-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/http-reference.adoc Outdated Show resolved Hide resolved
Quarkus Documentation automation moved this from To do to Review pending Nov 18, 2022
@loicmathieu
Copy link
Contributor Author

@gsmet I applied you suggestions.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand dismissed gsmet’s stale review November 21, 2022 07:43

Comments addressed

Quarkus Documentation automation moved this from Review pending to Reviewer approved Nov 21, 2022
@geoand geoand merged commit f914563 into quarkusio:main Nov 21, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 21, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 21, 2022
@loicmathieu loicmathieu deleted the k8s-guide branch November 22, 2022 11:43
@gsmet gsmet modified the milestones: 2.14.2.Final, 2.13.6.Final Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants