Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement native test for the gRPC / Hibernate ITs #29377

Merged
merged 1 commit into from Nov 28, 2022

Conversation

cescoffier
Copy link
Member

Fix #22619

@cescoffier cescoffier added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/grpc gRPC labels Nov 21, 2022
@alesj
Copy link
Contributor

alesj commented Nov 21, 2022

@cescoffier I would abstract those init/cleanup methods, so you don't have them duplicated all over the tests.

And there is a grpc-test-utils lib in test-framework module that already does all that - init and close.
So that we have this init/close handling at a single place; e.g. we might want to change how we close the GrpcClient(Channel)

@cescoffier
Copy link
Member Author

@alesj It would requires introducing 3 new abstract classes with the same level of duplication.

The tests are already extending a class, so we are kind of limited. However, I can move some code into a helper class.

@cescoffier
Copy link
Member Author

@alesj I pushed a new version reducing the code duplication.

@cescoffier
Copy link
Member Author

@alesj can you have another look?

@cescoffier cescoffier merged commit bd1d074 into quarkusio:main Nov 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 28, 2022
@cescoffier cescoffier deleted the grpc-hibernate-native-tests branch November 28, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC area/hibernate-orm Hibernate ORM area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No native tests in grpc-hibernate module
2 participants