Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scm information to metadata from top-level, and remove nesting #29384

Merged
merged 1 commit into from Nov 21, 2022

Conversation

holly-cummins
Copy link
Contributor

Follow-up to change the design of #28009 a bit. Adding scm information at the top level needs schema changes in the registry, and the information should logically be considered metadata. I've moved it down a level, and got rid of nesting to make sure tools don't get confused by nested structures within the nested structure.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven labels Nov 21, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 21, 2022

Failing Jobs - Building 1a7563f

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/reactive-messaging-kafka 

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorIT.testPets - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Unable to successfully launch process '21987'. Exit code is: '1'.
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:337)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:110)

@holly-cummins
Copy link
Contributor Author

I think the failing kafka tests must be unrelated to these changes. The maven windows tests are more suspicious, but looking through the logs, I can't see anything obvious. Does that build sometimes run out of time?

@gastaldi gastaldi merged commit a2e7f7e into quarkusio:main Nov 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 21, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants