Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure GraalVM js artifact is consistent with the SDK version #29405

Merged
merged 1 commit into from Nov 22, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 22, 2022

@ppalaga
Copy link
Contributor

ppalaga commented Nov 22, 2022

@gsmet thanks, this makes the life of Camel Quarkus easier in the community, but IIRC, org.graalvm.js:js is not available on Mandrel (cc @zakkak @galderz ). If that's really the case this will make the life of the prod team harder. Note that the js-dsl extension is not supported in CEQ product currently and will hardly be in the future because of the above. @lburgazzoli may want to add his/Camel K perspective.

@gsmet
Copy link
Member Author

gsmet commented Nov 22, 2022

I'm not entirely sure this would have any consequence on the prod team. It should just be an additional constraint, not something that needs packaging.

But I will let @aloubyansky to comment on this.

@gsmet gsmet requested a review from zakkak November 22, 2022 12:40
@gsmet
Copy link
Member Author

gsmet commented Nov 22, 2022

Pinging @zakkak too.

@lburgazzoli
Copy link
Contributor

Note that the js-dsl extension is not supported in CEQ product currently and will hardly be in the future because of the above. @lburgazzoli may want to add his/Camel K perspective.

I don't think that we will have the js-dsl in the produce any time soon so I'm fine with everything that reduces the maintenance

@zakkak
Copy link
Contributor

zakkak commented Nov 22, 2022

@gsmet thanks, this makes the life of Camel Quarkus easier in the community, but IIRC, org.graalvm.js:js is not available on Mandrel (cc @zakkak @galderz ).

Correct

If that's really the case this will make the life of the prod team harder.

I am not sure that's true. There are other parts of GraalVM that are not supported in Mandrel as well (and thus not supported in the product), but AFAIK this has not caused any major issues before.

Note that the js-dsl extension is not supported in CEQ product currently and will hardly be in the future because of the above. @lburgazzoli may want to add his/Camel K perspective.

That makes sense.

I'm not entirely sure this would have any consequence on the prod team. It should just be an additional constraint, not something that needs packaging.

But I will let @aloubyansky to comment on this.

+1

@aloubyansky
Copy link
Member

AFAICS, it's not a problem for prod.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 22, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 22, 2022

Failing Jobs - Building 97b10e5

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17 MacOS M1
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/reactive-messaging-hibernate-orm 

📦 integration-tests/reactive-messaging-hibernate-orm

io.quarkus.it.kafka.KafkaConnectorTest.testFruits line 50 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <1> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/reactive-messaging-hibernate-orm 

📦 integration-tests/reactive-messaging-hibernate-orm

io.quarkus.it.kafka.KafkaConnectorTest.testFruits line 50 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <1> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@gsmet gsmet merged commit dfbfb02 into quarkusio:main Nov 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 22, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 22, 2022
@gsmet
Copy link
Member Author

gsmet commented Nov 22, 2022

@ozangunalp I don't know what's happening with this test lately but it has been extremely unstable. Either we fix it quickly or we need to disable it.

@ozangunalp
Copy link
Contributor

@gsmet Thanks for the heads up! I was preparing the fix: #29433

@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants