New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SnapStart integration enhancement #29637
Conversation
cescoffier
commented
Dec 2, 2022
- Write documentation
- Use SnapStart instead of CRaC to avoid the confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few suggestions and comments.
- Write documentation - Use SnapStart instead of CRaC to avoid the confusion
Very good idea to break Crac and Snapstart up in the code. |
SnapStart is only for Amazon Lambda right ? My understanding is that CRaC support was removed now, it's a little shame as it was promising but I understand that such early tech is not yet supported. |
@loicmathieu this PR doesn't remove any CRaC feature. |
@loicmathieu CracConfig was introduced very recently as a placeholder for SnapStart - before we can use that name in public. It does not remove the CRaC support, it just makes things less confusing, as if you would have used the SnapStart feature with another CRaC impl.... bad things would have happened. |
@gsmet @cescoffier I see now that CRaC support is in |