Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using Gradle addExtension task without property file #29683

Merged
merged 1 commit into from Dec 6, 2022
Merged

Allow using Gradle addExtension task without property file #29683

merged 1 commit into from Dec 6, 2022

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Dec 5, 2022 •
edited by gsmet

This validate gradle.properties file exists before trying to writing on it.

Fixes #29663

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 5, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Dec 5, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 5, 2022

Failing Jobs - Building 1c16ec1

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand geoand merged commit cd053ff into quarkusio:main Dec 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 6, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 6, 2022
@gsmet gsmet mentioned this pull request Dec 6, 2022
Closed
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.0.Final Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.15.0.Final
Development

Successfully merging this pull request may close these issues.

gradle addExtension fails if you have no root properties file defined
4 participants
@glefloch @gastaldi @geoand @gsmet