Properly sort beans in DevUI beans page

[geoand]

Fixes: #29723

[mkouba]

Is this really needed? I don't see a benefit of this change. I mean why should e.g. the io.smallrye.config.inject.ConfigProducer go before io.quarkus.vertx.http.runtime.CurrentVertxRequest?

[geoand]

It is needed because you can have application beans that are generated.

[mkouba]

But generated application beans are handled in the DevBeanInfo#compare(), or?

[geoand]

My point is that you can have beans that are both application beans and generated beans and some come from Quarkus (with no user action).
So by doing this the Quarkus ones are moved to the bottom

[mkouba]

Well, I don't think that ordering matters here because users are probably not interested in generated beans anyway (be it a quarkus class or not).

In other words, this should be enough (and already quite confusing ;-):

1. application beans, non-generated, sorted by providerType name
2. application beans, generated, sorted by providerType name
3. non-app beans, non-generated, sorted by providerType name
4. non-app beans, generated, sorted by providerType name

[geoand]

io.quarkus.resteasy.reactive.server.runtime.NotFoundExceptionMapper$GeneratedExceptionHandlerFor$NotFoundException$OfMethod$toResponse, io.quarkus.resteasy.reactive.server.runtime.exceptionmappers.AuthenticationFailedExceptionMapper$GeneratedExceptionHandlerFor$AuthenticationFailedException$OfMethod$handle among a few others.

These are always included with RESTEasy Reactive

[mkouba]

Anyway, it's not a blocker so I'm going to approve this pr ;-)

[mkouba]

io.quarkus.resteasy.reactive.server.runtime.NotFoundExceptionMapper$GeneratedExceptionHandlerFor$NotFoundException$OfMethod$toResponse, io.quarkus.resteasy.reactive.server.runtime.exceptionmappers.AuthenticationFailedExceptionMapper$GeneratedExceptionHandlerFor$AuthenticationFailedException$OfMethod$handle among a few others.

These are always included with RESTEasy Reactive

Yes, but these are generated and should go after non-generated app beans...?

[geoand]

That's my point. Without this change, they are displayed before the generated beans that are a result of the user writing some code.

[mkouba]

I was wondering what those "non-quarkus application generated beans" are...

[quarkus-bot]

Failing Jobs - Building 4667cd7

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✖	JVM Tests - JDK 17 MacOS M1	Set up runner	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 341 more

📦 extensions/vertx/deployment

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 144 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <10> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 121 - More details - Source on GitHub

java.lang.AssertionError: 

Expected: a collection containing "Test MDC value ### Test 1"