Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix security concept doc listed as tutorial on index #29742

Merged
merged 1 commit into from Dec 9, 2022
Merged

Fix security concept doc listed as tutorial on index #29742

merged 1 commit into from Dec 9, 2022

Conversation

michelle-purcell
Copy link
Contributor

@michelle-purcell michelle-purcell commented Dec 7, 2022 •
edited by gsmet

Fixes #29727.

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Dec 7, 2022
@michelle-purcell michelle-purcell mentioned this pull request Dec 7, 2022
Closed
@gsmet
Copy link
Member

gsmet commented Dec 8, 2022 •
edited

Hey @michelle-purcell , when creating a PR that fixes an issue, make sure you use the following pattern: Fixes #29727 without any intermediary word (it also works with Fix, Closes, Close, capitalized or not). That way GitHub knows the PR is actually fixing the issue and will close the issue when the PR is merged.

I fixed the description of this one. And you can see the issue listed just here ---------------------------------------------------------->

@michelle-purcell
Copy link
Contributor Author

@gsmet - Gotcha 👍 Apologies 😊

Quarkus Documentation automation moved this from To do to Reviewer approved Dec 9, 2022
@gsmet gsmet merged commit 4d13cf2 into quarkusio:main Dec 9, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Dec 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 9, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
@michelle-purcell michelle-purcell deleted the QDOCS-68 branch May 8, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@ebullient ebullient Awaiting requested review from ebullient

Assignees
No one assigned
Labels
area/documentation kind/bugfix
Projects
Quarkus Documentation
Done
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

A concept guide is incorrectly listed as a tutorial content type on the new Documentation index page
2 participants
@michelle-purcell @gsmet