Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a CreationException if a normal scoped synthetic bean creates null #29775

Merged
merged 1 commit into from Dec 9, 2022
Merged

Throw a CreationException if a normal scoped synthetic bean creates null #29775

merged 1 commit into from Dec 9, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 9, 2022

  • follow the rules defined for normal scoped producer methods and fields where an IllegalProductException must be thrown instead

This pull request should supersede #29773

@mkouba
Throw a CreationException if a normal scoped synthetic bean creates null
84d1e23 
- follow the rules defined for normal scoped producer methods and fields
where an IllegalProductException must be thrown instead
@mkouba mkouba marked this pull request as ready for review December 9, 2022 13:46
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Dec 9, 2022
@geoand
Copy link
Contributor

geoand commented Dec 9, 2022 •
edited

Darn I was just about to open this :)

@mkouba mkouba mentioned this pull request Dec 9, 2022
Closed
@mkouba
Copy link
Contributor Author

mkouba commented Dec 9, 2022

DArn I was just about to open this :)

Feel free to comment if you have a better solution! ;-)

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 9, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Dec 9, 2022

DArn I was just about to open this :)

Feel free to comment if you have a better solution! ;-)

This is great :)

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2022

Failing Jobs - Building 84d1e23

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@manovotn manovotn merged commit 10fa7eb into quarkusio:main Dec 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 9, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 9, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkouba @geoand @manovotn @gsmet