Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in KeycloakDevServicesProcessor #29948

Merged
merged 1 commit into from Dec 19, 2022
Merged

Fix NPE in KeycloakDevServicesProcessor #29948

merged 1 commit into from Dec 19, 2022

Conversation

jmartisk
Copy link
Contributor

Fixes #29946

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 19, 2022

Failing Jobs - Building 490aeb6

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@sberyozkin
Copy link
Member

Thanks Jan, but let me check, I'm 100% sure I created a PR doing exactly the same fix and was certain it was resolved, may be I did not merge that PR, let me check

sberyozkin
sberyozkin approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see my fix was not complete now for this case,
thanks Jan for fixing it

@sberyozkin sberyozkin merged commit 4c7ca3b into quarkusio:main Dec 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 19, 2022
@jmartisk
Copy link
Contributor Author

@gsmet this PR "fixes" the fix done via #29314 and that was only backported to 2.14 AFAIK, so if this one is to be backported to 2.13, it only makes sense if the original one gets backported too.

@jmartisk
Copy link
Contributor Author

Or actually, probably this doesn't need to go to 2.13 at all, because that version doesn't suffer from the NPE - it doesn't have the PR that introduced the NPE (#28327)

@jmartisk jmartisk deleted the main-issue-29946 branch December 19, 2022 11:18
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/oidc kind/bugfix
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

NPE in KeycloakDevServicesProcessor again
3 participants
@jmartisk @sberyozkin @gsmet