Add a MongoDB client extension #3022

cescoffier · 2019-06-28T13:33:54Z

This is the first version of the Mongo extension.

It:

works in both JVM and native mode
proposes an imperative client (regular mongo client) and a reactive one (based on the reactive streams mongo driver)
supports authentication and TLS (even in native mode), but does not support mongo+srv:// in native mode (SVM limitation)
supports the hot reload

gsmet

I made a big review of the documentation part, NOT the code.

I think we should try to be consistent about the MongoDB naming but I let you decide what you prefer.

docs/src/main/asciidoc/mongo-guide.adoc

core/deployment/src/main/java/io/quarkus/deployment/builditem/FeatureBuildItem.java

docs/src/main/asciidoc/mongo-guide.adoc

cescoffier · 2019-07-02T17:59:58Z

Ok, I believe we reached a milestone. I'm going to re-organized my commits and ask for a review.

gsmet

I added another round of comments.

I still think there are too many commits. Typically ac046f2 should be squashed as it really has no value.

extensions/mongo-client/deployment/pom.xml

extensions/mongo-client/pom.xml

extensions/mongo-client/runtime/pom.xml

extensions/pom.xml

integration-tests/pom.xml

...ongo-client/deployment/src/main/java/io/quarkus/mongo/deployment/CodecProviderBuildItem.java

.../mongo-client/deployment/src/main/java/io/quarkus/mongo/deployment/MongoClientProcessor.java

extensions/mongo-client/runtime/src/main/java/io/quarkus/mongo/runtime/MongoClientTemplate.java

.../mongo-client/deployment/src/main/java/io/quarkus/mongo/deployment/MongoClientProcessor.java

cescoffier · 2019-07-05T14:08:56Z

I've reduced the number of commits.

gsmet · 2019-07-09T14:10:37Z

@cescoffier could you rebase, there are some conflicts with the pom files. It should be simple enough to fix.

gsmet · 2019-07-09T14:12:22Z

...ns/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/impl/ReactiveMongoClientImpl.java

@@ -0,0 +1,290 @@
+package io.quarkus.mongodb.impl;


The convention until now was to have the impl classes in the runtime package so it should be io.quarkus.mongodb.runtime.

This module exposes an API, it would be weird to be in a runtime quarkus-specific structure. That being said, for implementation, I don't see an issue.

Well, this is the convention we decided. I wanted impl/spi packages but got ruled out.

So right now, the conventions we have are:
io.quarkus.<extension>: the potential runtime API
io.quarkus.<extension>.runtime: everything that is not API (you can have an impl subpackage here if you want)
io.quarkus.<extension>.deployment: everything from the deployment artifact

cescoffier · 2019-07-09T14:25:20Z

Rebase done.

…and feature coverage in native mode. Inject both reactive and imperative client Extend configuration support for both the imperative and reactive clients Add an integration test for the reactive client Fix credential and write concern configuration Remove the new for having quarkus-reactive-streams-operators as a dependency of projects using the mongo client Re-inject the client so it get the new config Close the client during the hot reload so we don't have a connection shortage Register SSL support if not explicitly disabled Provide a substitution for the DNS lookup. However it won't work until Substrate provide a non-blocking multicast implementation. Declare the mongo version and the mongo extension in the bom.

Fix integration tests It works better when you start the database, weird, isn't it? Also align with the embedded mongo used in the runtime tests

Also, the number of databases created by default differs on Mac and Linux. So, reduce the number of documents as on Windows the number of connection is limited to 500.

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

This includes: * module rename (artifactId, name...) * package rename * directory rename Use duration instead of time in milliseconds. Rename MongoDB directories, artifactIds, project name and package name Replace SLF4J with JBoss Logging

gsmet · 2019-07-10T08:20:41Z

I properly rebased to avoid the merge commit as it makes the history harder to read and adjusted a few things.

I will wait for CI and merge.

rsvoboda · 2019-07-10T08:56:06Z

Thanks, just noticed that quarkus-quickstarts are broken due to missing quarkus-mongodb-client dependency for using-mongodb-client qs

gsmet · 2019-07-10T08:59:02Z

@rsvoboda yes, I'm waiting for CI before merging this one.

gsmet · 2019-07-10T11:14:26Z

And merged! Thanks @cescoffier and @loicmathieu !

cescoffier added this to Waiting for merge in Quarkus 1.0.0 Planning via automation Jul 1, 2019

cescoffier force-pushed the features/mongo-client-extension branch 2 times, most recently from 6de4de9 to 8c5145c Compare July 2, 2019 08:51

gsmet requested changes Jul 2, 2019

View reviewed changes

cescoffier force-pushed the features/mongo-client-extension branch from 9929df5 to 40cf523 Compare July 3, 2019 08:52

cescoffier added this to the 0.19.0 milestone Jul 3, 2019

cescoffier marked this pull request as ready for review July 3, 2019 08:52

cescoffier added area/persistence area/reactive labels Jul 3, 2019

gsmet requested changes Jul 5, 2019

View reviewed changes

gsmet reviewed Jul 5, 2019

View reviewed changes

.../mongo-client/deployment/src/main/java/io/quarkus/mongo/deployment/MongoClientProcessor.java Outdated Show resolved Hide resolved

cescoffier force-pushed the features/mongo-client-extension branch from 84d183c to 589ddc1 Compare July 5, 2019 14:08

gsmet changed the title ~~mongo client extension~~ Add a MongoDB client extension Jul 9, 2019

gsmet added the release/noteworthy-feature label Jul 9, 2019

gsmet reviewed Jul 9, 2019

View reviewed changes

cescoffier and others added 11 commits July 10, 2019 09:46

First version of the mongodb extension

c47be9a

Add a simple support for codec and codec provider

d3f46ae

Initial support of the MongoClient configuration.

5c8a402

Fix read preferences and other settings

614be4b

Fix integration tests It works better when you start the database, weird, isn't it? Also align with the embedded mongo used in the runtime tests

Explicitly mark the mongo+srv unsupported in native mode

59109d1

Also, the number of databases created by default differs on Mac and Linux. So, reduce the number of documents as on Windows the number of connection is limited to 500.

Add Mongo documentation

8c60aa1

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Rename modules to quarkus-mongodb-client

814c771

This includes: * module rename (artifactId, name...) * package rename * directory rename Use duration instead of time in milliseconds. Rename MongoDB directories, artifactIds, project name and package name Replace SLF4J with JBoss Logging

Do not rely on ClassInfo.toString()

0c6e2c2

Remove useless test checking whether SSL is explicitly disabled.

e566cc6

Update doc to use the new package name.

0192e4d

cescoffier and others added 3 commits July 10, 2019 09:49

Align the documentation with the quickstart

1b7b89a

Rename template to recorder in the MongoDB extension

b935599

Add a missing @OverRide

0f9a0a9

gsmet force-pushed the features/mongo-client-extension branch from a0bd6cf to 0f9a0a9 Compare July 10, 2019 08:19

gsmet approved these changes Jul 10, 2019

View reviewed changes

gsmet merged commit aa4e5e9 into quarkusio:master Jul 10, 2019

Quarkus 1.0.0 Planning automation moved this from Waiting for merge to Done Jul 10, 2019

cescoffier deleted the features/mongo-client-extension branch January 21, 2020 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a MongoDB client extension #3022

Add a MongoDB client extension #3022

cescoffier commented Jun 28, 2019

gsmet left a comment

cescoffier commented Jul 2, 2019

gsmet left a comment

cescoffier commented Jul 5, 2019

gsmet commented Jul 9, 2019

gsmet Jul 9, 2019

cescoffier Jul 9, 2019

gsmet Jul 9, 2019

cescoffier commented Jul 9, 2019

gsmet commented Jul 10, 2019

rsvoboda commented Jul 10, 2019

gsmet commented Jul 10, 2019

gsmet commented Jul 10, 2019

Add a MongoDB client extension #3022

Add a MongoDB client extension #3022

Conversation

cescoffier commented Jun 28, 2019

gsmet left a comment

Choose a reason for hiding this comment

cescoffier commented Jul 2, 2019

gsmet left a comment

Choose a reason for hiding this comment

cescoffier commented Jul 5, 2019

gsmet commented Jul 9, 2019

gsmet Jul 9, 2019

Choose a reason for hiding this comment

cescoffier Jul 9, 2019

Choose a reason for hiding this comment

gsmet Jul 9, 2019

Choose a reason for hiding this comment

cescoffier commented Jul 9, 2019

gsmet commented Jul 10, 2019

rsvoboda commented Jul 10, 2019

gsmet commented Jul 10, 2019

gsmet commented Jul 10, 2019