Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a way for users to customize Flyway configuration #30656

Merged
merged 1 commit into from Jan 27, 2023
Merged

Introduce a way for users to customize Flyway configuration #30656

merged 1 commit into from Jan 27, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 27, 2023

This is useful for users who need to update Flyway's configuration after it has been populated by Quarkus but before it has been handed off to Flyway

Closes: #28502

@geoand geoand requested a review from gastaldi January 27, 2023 12:02
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Jan 27, 2023
@geoand geoand mentioned this pull request Jan 27, 2023
Closed
@geoand
Copy link
Contributor Author

geoand commented Jan 27, 2023 •
edited

We should probably follow up with a similar approach for Liquibase

@geoand
Introduce a way for users to customize Flyway configuration
c9f4445 
This is useful for users who need to update Flyway's configuration
after it has been populated by Quarkus but before it has been handed off to
Flyway

Closes: quarkusio#28502
@github-actions
Copy link

github-actions bot commented Jan 27, 2023 •
edited

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 27, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

gastaldi
gastaldi approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Quarkus Documentation automation moved this from To do to Reviewer approved Jan 27, 2023
@geoand geoand merged commit c3ec503 into quarkusio:main Jan 27, 2023
Quarkus Documentation automation moved this from Reviewer approved to Done Jan 27, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 27, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 27, 2023
@geoand geoand deleted the #28502 branch January 27, 2023 13:21
@gsmet gsmet mentioned this pull request Jan 30, 2023
Closed
@pedrolopix
Copy link

pedrolopix commented Mar 3, 2023 •
edited

I have this issue and its prevention to bumping quarkus, it will be available in version 2.x?

@geoand
Copy link
Contributor Author

geoand commented Mar 3, 2023

It is unlikely we will backport this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/flyway kind/enhancement New feature or request release/noteworthy-feature
Projects
Quarkus Documentation
Done
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.

Flyway transactional lock property
3 participants
@geoand @pedrolopix @gastaldi