Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default "password" for key stores #30708

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Remove default "password" for key stores #30708

merged 1 commit into from
Jan 31, 2023

Conversation

cescoffier
Copy link
Member

Fix #29573.

This should be considered as a breaking change for users using "password" as password.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 30, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Jan 30, 2023
@cescoffier cescoffier changed the title Avoids using "password" as default password when loading / reading key stores. Remove default "password" for key stores Jan 30, 2023
sberyozkin
sberyozkin approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Clement, would you also like to update Vertx HTTP as well (CertificateConfiguration I believe has a password default value)

@cescoffier
Copy link
Member Author

@sberyozkin I checked, it's only the value we display in the documentation. But you are right, the Javadoc is confusing (and wrong)

@cescoffier cescoffier force-pushed the avoid-using-hardcoded-password branch from 26d36c2 to 9d426d3 Compare January 30, 2023 14:54
@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier
Avoids using "password" as default password when loading / reading ke…
bca49a0 
…y stores.

Fix quarkusio#29573.

This should be considered as a breaking change for users using "password" as password.
@cescoffier cescoffier force-pushed the avoid-using-hardcoded-password branch from 9d426d3 to bca49a0 Compare January 31, 2023 07:27
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 31, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 31, 2023

Failing Jobs - Building bca49a0

Status Name Step Failures Logs Raw logs
⌛ Native Tests - Misc4 Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi merged commit 750a259 into quarkusio:main Jan 31, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 31, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 31, 2023
@rsvoboda
Copy link
Member

rsvoboda commented Feb 1, 2023

@cescoffier should be covered in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.17

@cescoffier cescoffier deleted the avoid-using-hardcoded-password branch February 2, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/grpc gRPC area/vertx kind/bugfix release/breaking-change triage/flaky-test
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.

Quarkus Vertx HTTP defines default keystore password
5 participants
@cescoffier @rsvoboda @sberyozkin @gsmet @gastaldi