Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanacheRepositoryResource should implement ReactiveRestDataResource #30715

Merged
merged 1 commit into from
Jan 30, 2023
Merged

PanacheRepositoryResource should implement ReactiveRestDataResource #30715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...arkus/hibernate/reactive/rest/data/panache/deployment/repository/CollectionsResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
import io.quarkus.hibernate.reactive.rest.data.panache.PanacheRepositoryResource;
import io.quarkus.rest.data.panache.MethodProperties;
import io.quarkus.rest.data.panache.ResourceProperties;
import io.smallrye.mutiny.Uni;

@ResourceProperties(hal = true, paged = false, halCollectionName = "item-collections", rolesAllowed = "user")
public interface CollectionsResource extends PanacheRepositoryResource<CollectionsRepository, Collection, String> {

@MethodProperties(rolesAllowed = "admin")
boolean delete(String name);
Uni<Boolean> delete(String name);
}
11 changes: 6 additions & 5 deletions ...st/data/panache/deployment/repository/PanacheRepositoryResourcePathCustomisationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.quarkus.rest.data.panache.MethodProperties;
import io.quarkus.rest.data.panache.ResourceProperties;
import io.quarkus.test.QuarkusUnitTest;
import io.smallrye.mutiny.Uni;

class PanacheRepositoryResourcePathCustomisationTest extends AbstractPathCustomisationTest {

Expand All @@ -27,18 +28,18 @@ public interface CustomPathCollectionsResource
extends PanacheRepositoryResource<CollectionsRepository, Collection, String> {

@MethodProperties(path = "api")
List<Collection> list(Page page, Sort sort);
Uni<List<Collection>> list(Page page, Sort sort);

@MethodProperties(path = "api")
Collection get(String name);
Uni<Collection> get(String name);

@MethodProperties(path = "api")
Collection add(Collection collection);
Uni<Collection> add(Collection collection);

@MethodProperties(path = "api")
Collection update(String name, Collection collection);
Uni<Collection> update(String name, Collection collection);

@MethodProperties(path = "api")
boolean delete(String name);
Uni<Boolean> delete(String name);
}
}
3 changes: 2 additions & 1 deletion .../main/java/io/quarkus/hibernate/reactive/rest/data/panache/PanacheRepositoryResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io.quarkus.hibernate.reactive.panache.PanacheRepositoryBase;
import io.quarkus.rest.data.panache.MethodProperties;
import io.quarkus.rest.data.panache.ReactiveRestDataResource;
import io.quarkus.rest.data.panache.ResourceProperties;
import io.quarkus.rest.data.panache.RestDataResource;

Expand All @@ -18,6 +19,6 @@
* @param <ID> ID type of the entity.
*/
public interface PanacheRepositoryResource<Repository extends PanacheRepositoryBase<Entity, ID>, Entity, ID>
extends RestDataResource<Entity, ID> {
extends ReactiveRestDataResource<Entity, ID> {

}