Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worker queue default size #3088

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Fix worker queue default size #3088

merged 1 commit into from
Jul 9, 2019

Conversation

stuartwdouglas
Copy link
Member

At the moment it is 0 which is no queue

dmlloyd
dmlloyd reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a sentinel value, might it be better to use OptionalInt and use non-present to mean 'unbounded'?

@gsmet
Copy link
Member

gsmet commented Jul 4, 2019

There is a test failure:

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.604 s <<< FAILURE! - in io.quarkus.maven.it.GenerateConfigIT
[ERROR] testAddExtensionWithASingleExtension  Time elapsed: 7.604 s  <<< FAILURE!
java.lang.AssertionError
	at io.quarkus.maven.it.GenerateConfigIT.testAddExtensionWithASingleExtension(GenerateConfigIT.java:43)

@stuartwdouglas stuartwdouglas added this to the 0.19.0 milestone Jul 9, 2019
@stuartwdouglas stuartwdouglas merged commit 6bae374 into quarkusio:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd left review comments

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stuartwdouglas @gsmet @dmlloyd @FroMage