Various small fixes #31358
Merged
Various small fixes #31358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
gastaldi
reviewed
Feb 22, 2023
independent-projects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/runner/Timing.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
When using <revision>, the version can actually be passed as "null" so we need to filter out this case. Also display the app name if not null, even if the version is null.
Failing Jobs - Building 1cb85f4
Full information is available in the Build summary check run. Failures⚙️ Maven Tests - JDK 11 #- Failing: integration-tests/maven
📦 integration-tests/maven✖ ✖ ⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖ ✖ |
|
Test failures are unrelated |
gastaldi
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on quarkus-github-bot and #31355