-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Quarkus Kubernetes gitops friendly #31373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
[x] Added new property `quarkus.kubernetes.idempotent=true` to avoid producing non idempotent resources. [x] Added new property `quarkus.kubernetes.output-directory` to select the target directory where to generate the resources. Fix quarkusio#26928 Fix quarkusio#15473 Fix quarkusio#31296
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
iocanel
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fedinskiy
added a commit
to fedinskiy/quarkus-test-suite
that referenced
this pull request
Jul 11, 2023
Quarkus 3 allows making K8s manifests more Git-friendly [1] We cover them with these changes, with a single exception[2] [1] quarkusio/quarkus#31373 [2] quarkusio/quarkus#34673
9 tasks
fedinskiy
added a commit
to fedinskiy/quarkus-test-suite
that referenced
this pull request
Jul 13, 2023
Quarkus 3 allows making K8s manifests more Git-friendly [1] We cover them with these changes, with a single exception[2] [1] quarkusio/quarkus#31373 [2] quarkusio/quarkus#34673
fedinskiy
added a commit
to fedinskiy/quarkus-test-suite
that referenced
this pull request
Jul 13, 2023
Quarkus 3 allows making K8s manifests more Git-friendly [1] We cover them with these changes, with a single exception[2] [1] quarkusio/quarkus#31373 [2] quarkusio/quarkus#34673
fedinskiy
added a commit
to fedinskiy/quarkus-test-suite
that referenced
this pull request
Jul 13, 2023
Quarkus 3 allows making K8s manifests more Git-friendly [1] We cover them with these changes, with a single exception[2] [1] quarkusio/quarkus#31373 [2] quarkusio/quarkus#34673
fedinskiy
added a commit
to fedinskiy/quarkus-test-suite
that referenced
this pull request
Jul 14, 2023
Quarkus 3 allows making K8s manifests more Git-friendly [1] We cover them with these changes, with a single exception[2] [1] quarkusio/quarkus#31373 [2] quarkusio/quarkus#34673
fedinskiy
added a commit
to quarkus-qe/quarkus-test-suite
that referenced
this pull request
Jul 14, 2023
Quarkus 3 allows making K8s manifests more Git-friendly [1] We cover them with these changes, with a single exception[2] [1] quarkusio/quarkus#31373 [2] quarkusio/quarkus#34673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quarkus.kubernetes.idempotent=true
to avoid producing non idempotent resources.quarkus.kubernetes.output-directory
to select the target directory where to generate the resources.Fix #26928
Fix #15473
Fix #31296