Exclude banned dependency commons-logging in the BOM #31414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/dependencies
This comment has been minimized.
This comment has been minimized.
|
Do I need to go through the test failures? |
|
Looks useful, not sure why nobody noticed. Would you mind resolving the conflicts and re-push? |
|
Yeah, I had a look at this one yesterday. I wanted to get back to it and fix the conflict to re-run CI on a fresh tree. |
gsmet
force-pushed
the
230225-bom-excluded
branch
from
fd9a12d
to
c610028
Compare
gsmet
reviewed
Oct 6, 2023
gsmet
added
the
triage/waiting-for-ci
|
Thanks for taking care, @gsmet! |
This comment has been minimized.
This comment has been minimized.
gastaldi
force-pushed
the
230225-bom-excluded
branch
from
c610028
to
f1f8de9
Compare
This comment has been minimized.
This comment has been minimized.
gastaldi
force-pushed
the
230225-bom-excluded
branch
from
f1f8de9
to
47d3e22
Compare
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Native Tests - Misc2 | Build |
Failures | Logs | Raw logs | 🚧 |
Failures
⚙️ Native Tests - Misc2 #
- Failing: integration-tests/logging-gelf
📦 integration-tests/logging-gelf
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.43.4:start (docker-start) on project quarkus-integration-test-logging-gelf: I/O Error
Flaky tests - Develocity
⚙️ JVM Tests - JDK 21
📦 extensions/smallrye-reactive-messaging-kafka/deployment
✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History
Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds.-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException:
Assertion condition
Expecting size of:
[]
to be greater than or equal to 2 but was 0 within 10 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
|
It's never too late, thanks @gastaldi for taking this over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30813 is related but this does not fix it because it does not add any automatic solution to add exclusion for all (or selected) banned dependencies.