Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: add a build item to mark bean archives as known compatible with Quarkus #31856

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Mar 15, 2023

Fixes #31378

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Mar 15, 2023
@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 16, 2023

Rebased and marking as ready.

@Ladicek Ladicek marked this pull request as ready for review March 16, 2023 10:20
@Ladicek Ladicek requested a review from mkouba March 16, 2023 10:20
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 16, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 16, 2023

Failing Jobs - Building b4d7373

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 44 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2136)

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 17, 2023

Failures are known flaky tests, merging.

@Ladicek Ladicek merged commit 924b450 into quarkusio:main Mar 17, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 17, 2023
@Ladicek Ladicek deleted the arc-bean-archives-warning branch March 17, 2023 10:42
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 17, 2023
@melloware
Copy link
Contributor

@Ladicek maybe I am doing something wrong but I added this to my Processor but still seeing this CDI Lite warning with .Beta1.

    @BuildStep
    void produceKnownCompatible(BuildProducer<KnownCompatibleBeanArchiveBuildItem> knownCompatibleProducer) {
        knownCompatibleProducer.produce(new KnownCompatibleBeanArchiveBuildItem("org.omnifaces", "omnifaces"));
    }

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 27, 2023

@melloware Sorry, was on PTO. Can you point me to a piece of code (maybe a branch of your extension) I can build and try debugging?

@melloware
Copy link
Contributor

melloware commented Mar 27, 2023

@Ladicek sure I just committed my change to my extension: https://github.com/quarkiverse/quarkus-omnifaces

If you run the build you will still see the warnings even though in my processor I have the KnownCompatibleBeanArchiveBuildItem Thanks!

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 29, 2023

Sorry it took me so long to get to this. I know where the problem is -- I'm using a HashSet to store the set of known-compatible bean archives, but the objects put into the HashSet do not define equality and hash code :-/ The only thing I can say to my defense is that noone noticed it in review either 😆

Fix is simple, see #32213

@melloware
Copy link
Contributor

No worries! Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArC - Warning about CDI Lite and bean discovery mode
3 participants