Adjust RestClientBaseTest temp directory handling #31996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some issues with JUnit @tempdir on Windows with this test. Let's use more traditional constructs.
geoand
approved these changes
Mar 21, 2023
Sgitario
approved these changes
Mar 21, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
added a commit
to gsmet/quarkus
that referenced
this pull request
Nov 7, 2023
Unfortunately, using @tempdir on Windows CI is not working very well and this test has been failing from time to time for a few days now. Applying the same trick as in quarkusio#31996
gsmet
added a commit
to gsmet/quarkus
that referenced
this pull request
Nov 15, 2023
Unfortunately, using @tempdir on Windows CI is not working very well and this test has been failing from time to time for a few days now. Applying the same trick as in quarkusio#31996 (cherry picked from commit a71f2dc)
DavideD
pushed a commit
to DavideD/quarkus
that referenced
this pull request
Nov 27, 2023
Unfortunately, using @tempdir on Windows CI is not working very well and this test has been failing from time to time for a few days now. Applying the same trick as in quarkusio#31996
aloubyansky
pushed a commit
to aloubyansky/quarkus
that referenced
this pull request
Jan 15, 2024
Unfortunately, using @tempdir on Windows CI is not working very well and this test has been failing from time to time for a few days now. Applying the same trick as in quarkusio#31996
aloubyansky
pushed a commit
to aloubyansky/quarkus
that referenced
this pull request
Jan 15, 2024
Unfortunately, using @tempdir on Windows CI is not working very well and this test has been failing from time to time for a few days now. Applying the same trick as in quarkusio#31996
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this pull request
Feb 8, 2024
Unfortunately, using @tempdir on Windows CI is not working very well and this test has been failing from time to time for a few days now. Applying the same trick as in quarkusio#31996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some issues with JUnit @tempdir on Windows with this test. Let's use more traditional constructs.