Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigPhase.BUILD_AND_RUN_TIME_FIXED values to example config file #3220

Merged
merged 1 commit into from Jul 14, 2019
Merged

Add ConfigPhase.BUILD_AND_RUN_TIME_FIXED values to example config file #3220

merged 1 commit into from Jul 14, 2019

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Jul 14, 2019

Fixes #3218

gsmet
gsmet approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 14, 2019
@stuartwdouglas stuartwdouglas merged commit 08fe2d3 into quarkusio:master Jul 14, 2019
@gwenneg gwenneg deleted the issue-3218-cors-in-generated-application-properties branch July 15, 2019 06:09
@gsmet gsmet added this to the 0.20.0 milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Generated application.properties.example doesn't include CORS property
3 participants
@gwenneg @stuartwdouglas @gsmet