Adapts AWT extension to the new dynamic .so loading [JDK 17, 19, 20] #32432

Karm · 2023-04-05T13:12:26Z

Fixes #31596 (JDK 17)

quarkus-bot · 2023-04-05T13:12:46Z

core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageJNIConfigStep.java

Karm · 2023-04-05T21:47:02Z

@zakkak JDK 20 is fine, but I need to add version conditions to maintain compatibility with older 22.x Mandrel/GraalVM....

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

Karm · 2023-04-08T22:48:10Z

@zakkak I've got the version condition in. I'll adapt your PR about removing raw JSON and test again. THX 👍

Karm · 2023-04-11T12:19:16Z

I am testing it now again with the latest changes purging raw JSON and there are some backward compatibility issues atm...

Version	Status
GraalVM 22.3.1 Java 17 CE (Java Version 17.0.6+10-jvmci-22.3-b13)	🔴
GraalVM 23.0.0-dev Java 17.0.7+4-jvmci-23.0-b09 CE (Java Version 17.0.7+4-jvmci-23.0-b09)	🟢

Karm · 2023-04-11T14:04:56Z

Much better now

Version	Status
GraalVM 22.3.1 Java 17 CE (Java Version 17.0.6+10-jvmci-22.3-b13)	🟢
GraalVM 23.0.0-dev Java 17.0.7+4-jvmci-23.0-b09 CE (Java Version 17.0.7+4-jvmci-23.0-b09)	🟢
GraalVM 23.0.0-dev Java 19.0.1+10-jvmci-23.0-b04 CE (Java Version 19.0.1+10-jvmci-23.0-b04)	🔴
GraalVM 23.0.0-dev Java 20+34-jvmci-23.0-b09 CE (Java Version 20+34-jvmci-23.0-b09)	🟢
native-image 17.0.7 2023-04-18
GraalVM Runtime Environment GraalVM CE 17.0.7-dev+4.1 (build 17.0.7+4-jvmci-23.0-b10)
Substrate VM GraalVM CE 17.0.7-dev+4.1 (build 17.0.7+4, serial gc)	🟢
native-image 20 2023-03-21
GraalVM Runtime Environment GraalVM CE 20-dev+34.1 (build 20+34-jvmci-23.0-b10)
Substrate VM GraalVM CE 20-dev+34.1 (build 20+34, serial gc)	🟢
native-image 23.0.0-deva81ecbe6def2 Mandrel Distribution (Java Version 17.0.8-internal+0-adhoc.karm.jdk17u-dev)	🟢
native-image 23.0.0-deva81ecbe6def2 Mandrel Distribution (Java Version 20-internal-adhoc.karm.jdk20)	🟢
native-image 22.3.1.0-Final Mandrel Distribution (Java Version 17.0.6+10)	🟢

extensions/awt/runtime/src/main/java/io/quarkus/awt/runtime/JDKSubstitutions.java

jerboaa

LGTM, but please double check the color profile resources aren't included by default already.

extensions/awt/deployment/src/main/java/io/quarkus/awt/deployment/AwtProcessor.java

Karm · 2023-04-11T22:45:23Z

Version	Status
GraalVM 22.3.1 Java 17 CE (Java Version 17.0.6+10-jvmci-22.3-b13)	🟢
GraalVM 22.3.1 Java 19 CE (Java Version 19.0.2+7-jvmci-22.3-b12)	🟢
GraalVM 23.0.0-dev Java 17.0.7+4-jvmci-23.0-b09 CE (Java Version 17.0.7+4-jvmci-23.0-b09)	🟢
GraalVM 23.0.0-dev Java 19.0.1+10-jvmci-23.0-b04 CE (Java Version 19.0.1+10-jvmci-23.0-b04)	🟢
GraalVM 23.0.0-dev Java 20+34-jvmci-23.0-b09 CE (Java Version 20+34-jvmci-23.0-b09)	🟢
native-image 17.0.7 2023-04-18
GraalVM Runtime Environment GraalVM CE 17.0.7-dev+4.1 (build 17.0.7+4-jvmci-23.0-b10)
Substrate VM GraalVM CE 17.0.7-dev+4.1 (build 17.0.7+4, serial gc)	🟢
native-image 20 2023-03-21
GraalVM Runtime Environment GraalVM CE 20-dev+34.1 (build 20+34-jvmci-23.0-b10)
Substrate VM GraalVM CE 20-dev+34.1 (build 20+34, serial gc)	🟢
native-image 23.0.0-deva81ecbe6def2 Mandrel Distribution (Java Version 17.0.8-internal+0-adhoc.karm.jdk17u-dev)	🟢
native-image 23.0.0-deva81ecbe6def2 Mandrel Distribution (Java Version 20-internal-adhoc.karm.jdk20)	🟢
native-image 22.3.1.0-Final Mandrel Distribution (Java Version 17.0.6+10)	🟢

I am content with it now. It's IMHO ready for a review @geoand @gastaldi @zakkak

gastaldi

LGTM, it would be nice to have a Javadoc on the new BuildItems

...rc/main/java/io/quarkus/deployment/builditem/nativeimage/JniRuntimeAccessFieldBuildItem.java

...c/main/java/io/quarkus/deployment/builditem/nativeimage/JniRuntimeAccessMethodBuildItem.java

gastaldi · 2023-04-11T23:11:39Z

Awesome! Please squash them all before we merge it. Good job!

quarkus-bot · 2023-04-12T05:43:32Z

Failing Jobs - Building `a354621`

Status	Name	Step	Failures	Logs	Raw logs
✔️	Gradle Tests - JDK 11
⌛	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✔️	JVM Tests - JDK 19
⌛	Native Tests - Security1	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.0.2-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 105 - More details - Source on GitHub

java.lang.NullPointerException
	at io.quarkus.gradle.builder.QuarkusModelBuilderTest.assertProjectModule(QuarkusModelBuilderTest.java:152)
	at io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel(QuarkusModelBuilderTest.java:105)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleDevModel line 49 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.0.2-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleTestModel line 43 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

✖ io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/opentelemetry-jdbc-instrumentation

📦 integration-tests/opentelemetry-jdbc-instrumentation

✖ io.quarkus.it.opentelemetry.PostgresOpenTelemetryJdbcInstrumentationTest.testPostgreSqlQueryTraced line 14 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: JDBC insert statement was not traced. ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

Karm · 2023-04-12T07:40:12Z

I don't think the OpenTelemetry JDBC instrumentation would be related...

geoand · 2023-04-12T07:41:02Z

Yes, that's a flaky test

geoand · 2023-04-12T11:05:34Z

Let's wait for a final approval from @zakkak or @jerboaa

jerboaa

LGTM.

Karm requested a review from zakkak April 5, 2023 13:12

Karm self-assigned this Apr 5, 2023

quarkus-bot bot added area/core area/graphics labels Apr 5, 2023

zakkak reviewed Apr 5, 2023

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageJNIConfigStep.java Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Karm changed the title ~~Adapts AWT extension to the new dynamic .so loading [JDK 17]~~ Adapts AWT extension to the new dynamic .so loading [JDK 17, JDK 20] Apr 5, 2023

Karm marked this pull request as draft April 5, 2023 21:46

zakkak reviewed Apr 7, 2023

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java Show resolved Hide resolved

zakkak mentioned this pull request Apr 7, 2023

AppReproducersTest.imageioAWTTest fails with 23.0.0-dev tree after AWT change Karm/mandrel-integration-tests#143

Closed

Karm force-pushed the issue-31596 branch from d007749 to 736a75d Compare April 8, 2023 22:44

Karm force-pushed the issue-31596 branch from 736a75d to 764dacb Compare April 11, 2023 11:10

Karm force-pushed the issue-31596 branch from 764dacb to 6b2cc49 Compare April 11, 2023 13:36

Karm marked this pull request as ready for review April 11, 2023 13:38

gastaldi reviewed Apr 11, 2023

View reviewed changes

extensions/awt/runtime/src/main/java/io/quarkus/awt/runtime/JDKSubstitutions.java Outdated Show resolved Hide resolved

jerboaa approved these changes Apr 11, 2023

View reviewed changes

extensions/awt/deployment/src/main/java/io/quarkus/awt/deployment/AwtProcessor.java Show resolved Hide resolved

This comment has been minimized.

Sign in to view

gastaldi approved these changes Apr 11, 2023

View reviewed changes

...rc/main/java/io/quarkus/deployment/builditem/nativeimage/JniRuntimeAccessFieldBuildItem.java Show resolved Hide resolved

...c/main/java/io/quarkus/deployment/builditem/nativeimage/JniRuntimeAccessMethodBuildItem.java Show resolved Hide resolved

Adapts AWT extension to the new dynamic .so loading [JDK 17,19,20]

a354621

Karm force-pushed the issue-31596 branch from 6c490f7 to a354621 Compare April 11, 2023 23:29

Karm changed the title ~~Adapts AWT extension to the new dynamic .so loading [JDK 17, JDK 20]~~ Adapts AWT extension to the new dynamic .so loading [JDK 17, 19, 20] Apr 11, 2023

geoand mentioned this pull request Apr 12, 2023

Disable flaky OpenTelemetry Jdbc instrumentation test #32559

Merged

jerboaa approved these changes Apr 12, 2023

View reviewed changes

gastaldi merged commit 32d6e66 into quarkusio:main Apr 12, 2023
43 of 46 checks passed

quarkus-bot bot added the kind/bugfix label Apr 12, 2023

quarkus-bot bot added this to the 3.1 - main milestone Apr 12, 2023

Karm mentioned this pull request Apr 13, 2023

Avoid using raw JSON Karm/quarkus#106

Closed

scrocquesel mentioned this pull request Apr 21, 2023

Fix generateJniConfig step #32829

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapts AWT extension to the new dynamic .so loading [JDK 17, 19, 20] #32432

Adapts AWT extension to the new dynamic .so loading [JDK 17, 19, 20] #32432

Karm commented Apr 5, 2023

quarkus-bot bot commented Apr 5, 2023

This comment has been minimized.

Karm commented Apr 5, 2023

Karm commented Apr 8, 2023

Karm commented Apr 11, 2023

Karm commented Apr 11, 2023

jerboaa left a comment

This comment has been minimized.

Karm commented Apr 11, 2023

gastaldi left a comment

gastaldi commented Apr 11, 2023

quarkus-bot bot commented Apr 12, 2023

Karm commented Apr 12, 2023

geoand commented Apr 12, 2023

geoand commented Apr 12, 2023

jerboaa left a comment

Adapts AWT extension to the new dynamic .so loading [JDK 17, 19, 20] #32432

Adapts AWT extension to the new dynamic .so loading [JDK 17, 19, 20] #32432

Conversation

Karm commented Apr 5, 2023

quarkus-bot bot commented Apr 5, 2023

This comment has been minimized.

Karm commented Apr 5, 2023

Karm commented Apr 8, 2023

Karm commented Apr 11, 2023

Karm commented Apr 11, 2023

jerboaa left a comment

Choose a reason for hiding this comment

This comment has been minimized.

Karm commented Apr 11, 2023

gastaldi left a comment

Choose a reason for hiding this comment

gastaldi commented Apr 11, 2023

quarkus-bot bot commented Apr 12, 2023

Failing Jobs - Building a354621

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/opentelemetry-jdbc-instrumentation

Karm commented Apr 12, 2023

geoand commented Apr 12, 2023

geoand commented Apr 12, 2023

jerboaa left a comment

Choose a reason for hiding this comment

Failing Jobs - Building `a354621`