-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Report an Issue
menu in DevUI
#32447
base: main
Are you sure you want to change the base?
Conversation
Hmm. How will this work for non community releases ? |
That's my concern in #32431 (comment), and the answer is no - at least not until we define how we'll parameterize that :) |
Marking it as a draft for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea a lot.
This comment has been minimized.
This comment has been minimized.
bom/application/pom.xml
Outdated
@@ -3280,7 +3281,11 @@ | |||
<version>${es-module-shims.version}</version> | |||
<scope>runtime</scope> | |||
</dependency> | |||
|
|||
<dependency> | |||
<groupId>org.zeroturnaround</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like zt-exec for sure but why are we needing to add this vs all the process exec utilities we already have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What process exec utilities we have are you referring to? java.lang.ProcessBuilder
or something specific?
|
||
public JsonObject reportBug() { | ||
URLBuilder urlBuilder = new URLBuilder( | ||
"https://github.com/quarkusio/quarkus/issues/new?assignees=&labels=kind%2Fbug&template=bug_report.yml"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we make this a config property which is overridable by platform the same way as builder images are ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking making it a qute template string so it can take in the info if applicable?
.addQueryParameter("quarkus_version", | ||
Objects.toString(getClass().getPackage().getImplementationVersion(), "999-SNAPSHOT")); | ||
|
||
if (OS.WINDOWS.isCurrent()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these calls be done wether the project has a build.gradle/build.kts and/or pom.xml file?
and what if they don't use mvnw/gradlew wrappers? should have fallback to call mvn/gradle in path?
- This opens up the GitHub issue with some prefilled data - Fixes quarkusio#32431
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Things to be worked on before marking this PR as ready:
Screen-Recording-2023-04-05-at-15.24.05.mov