Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Report an Issue menu in DevUI #32447

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Apr 5, 2023

Things to be worked on before marking this PR as ready:

  • Parameterize the issue tracker (as it will be different when running in RHBQ)
  • List the extensions and add to the report as Additional Context
Screen-Recording-2023-04-05-at-15.24.05.mov

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Apr 5, 2023
@maxandersen
Copy link
Contributor

Hmm. How will this work for non community releases ?

@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 5, 2023

Hmm. How will this work for non community releases ?

That's my concern in #32431 (comment), and the answer is no - at least not until we define how we'll parameterize that :)

@gastaldi gastaldi marked this pull request as draft April 5, 2023 20:03
@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 5, 2023

Marking it as a draft for now

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea a lot.

@quarkus-bot

This comment has been minimized.

@@ -3280,7 +3281,11 @@
<version>${es-module-shims.version}</version>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>org.zeroturnaround</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like zt-exec for sure but why are we needing to add this vs all the process exec utilities we already have?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What process exec utilities we have are you referring to? java.lang.ProcessBuilder or something specific?


public JsonObject reportBug() {
URLBuilder urlBuilder = new URLBuilder(
"https://github.com/quarkusio/quarkus/issues/new?assignees=&labels=kind%2Fbug&template=bug_report.yml");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make this a config property which is overridable by platform the same way as builder images are ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking making it a qute template string so it can take in the info if applicable?

.addQueryParameter("quarkus_version",
Objects.toString(getClass().getPackage().getImplementationVersion(), "999-SNAPSHOT"));

if (OS.WINDOWS.isCurrent()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these calls be done wether the project has a build.gradle/build.kts and/or pom.xml file?

and what if they don't use mvnw/gradlew wrappers? should have fallback to call mvn/gradle in path?

- This opens up the GitHub issue with some prefilled data
- Fixes quarkusio#32431
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/dev-ui area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report bugs from the DevUI
4 participants