Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky OpenTelemetry Jdbc instrumentation test #32712

Closed
wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 18, 2023

This test fails from time to time (see #32708 for example)

Similar to: #32559

This test fails from time to time (see quarkusio#32708 for example)

Similar to: quarkusio#32559
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 18, 2023

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@gsmet
Copy link
Member

gsmet commented Apr 18, 2023

I think @michalvavrik worked on fixing it here: #32697 .

And we should probably enable the PostgreSQL one again if it's actually fixed.

@geoand
Copy link
Contributor Author

geoand commented Apr 18, 2023

I'll leave it up to @brunobat then to decide

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are important. They have helped to find quite a few issues.
We disabled the PostgreSQL one but now we must fix the underlaying condition in
#32697

@geoand
Copy link
Contributor Author

geoand commented Apr 18, 2023

Cool, let's close this in that case

@geoand geoand closed this Apr 18, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants