Drop condition for GraalVM < 22.2 #32883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Apr 25, 2023
gastaldi
added
the
triage/waiting-for-ci
|
Note that |
This comment has been minimized.
This comment has been minimized.
The minimum required GraalVM version is 22.2 so there is no need to account for the old native-image logs. This also fixes an issue with GraalVM >= 23.0 where the version output changes and it no longer contains the "Version info:" string.
zakkak
force-pushed
the
2023-04-25-fix-gradle-latest-graal
branch
from
892435e
to
e9d26a7
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum required GraalVM version is 22.2 so there is no need to account for the old native-image logs.
This also fixes an issue with GraalVM >= 23.0 where the version output changes and it no longer contains the "Version info:" string.
Closes: #32678
Being tested in: https://github.com/graalvm/mandrel/actions/runs/4798433093