Include classes touched by parent for testing #33047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I'm excited about this fix, but from the description, I'm not sure if it fixes #27821. I feel like #27821 might need deeper changes to how we tell JUnit about our test's classloader; however, I think this change should fix an issue where changing a test template class doesn't trigger a test re-run, which would be great. |
When deciding if a test should be re-run we should also re-run the test if class level methods touched the changed class.
This comment has been minimized.
This comment has been minimized.
|
@holly-cummins I changed the description, should be good to go. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
@holly-cummins any chance you could give this one a review? |
holly-cummins
approved these changes
Jun 2, 2023
|
Thanks for the nudge, @stuartwdouglas - LGTM! |
gsmet
approved these changes
Jun 6, 2023
|
Merging as @holly-cummins approved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deciding if a test should be re-run we should also re-run the test if class level methods touched the changed class.