Scala language support #3399

miteshaghera · 2019-08-01T11:56:17Z

Initial support for Scala.

Fix for #1413

gsmet · 2019-08-01T13:13:39Z

Thanks for this. Looks like we have some test failures:

[INFO] Quarkus - Maven Plugin ............................. FAILURE [ 28.296 s]

miteshaghera · 2019-08-05T10:02:59Z

Hi @miteshaghera ,

Thanks for this. Looks like we have some test failures:
[INFO] Quarkus - Maven Plugin ............................. FAILURE [ 28.296 s]

I fixed for Quarkus - Maven Plugin but now it's failing for Quarkus - Gradle Plugin. By looking into logs I found following exception:

Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find io.quarkus:quarkus-bootstrap-parent:999-SNAPSHOT.
Searched in the following locations:
  - file:/D:/a/1/s/devtools/gradle/target/dependencies/io/quarkus/quarkus-bootstrap-parent/999-SNAPSHOT/maven-metadata.xml
  - file:/D:/a/1/s/devtools/gradle/target/dependencies/io/quarkus/quarkus-bootstrap-parent/999-SNAPSHOT/quarkus-bootstrap-parent-999-SNAPSHOT.pom
  - file:/D:/a/1/s/devtools/gradle/target/dependencies/io/quarkus/quarkus-bootstrap-parent/999-SNAPSHOT/quarkus-bootstrap-parent-999-SNAPSHOT.jar
  - https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bootstrap-parent/999-SNAPSHOT/maven-metadata.xml
  - https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bootstrap-parent/999-SNAPSHOT/quarkus-bootstrap-parent-999-SNAPSHOT.pom
  - https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bootstrap-parent/999-SNAPSHOT/quarkus-bootstrap-parent-999-SNAPSHOT.jar

Do I need to change anything to support scala in gradle plugin?

gsmet

@miteshaghera looks good to me except for a small comment.

Could you fix it? If you can squash everything into one commit, that would be appreciated too.

In the meantime, I'll try to create a Scala project and see how it goes.

devtools/common/src/main/filtered/extensions.json

core/deployment/src/main/java/io/quarkus/deployment/builditem/FeatureBuildItem.java

gsmet

OK I tried to create a project and found a couple more issues.

Could you check what's going on?

Thanks!

devtools/common/src/main/java/io/quarkus/generators/SourceType.java

devtools/common/src/main/resources/templates/basic-rest/scala/pom-template.ftl

miteshaghera · 2019-08-14T20:34:19Z

@miteshaghera looks good to me except for a small comment.

Could you fix it? If you can squash everything into one commit, that would be appreciated too.

In the meantime, I'll try to create a Scala project and see how it goes.

I have to add entry in extensions.json to make build successful for quarkus:create . However I omitted guide key as we don't have guide yet.

gsmet

I added a couple more comments.

Could you also add a test of project creation? Considering it was broken, we really need one. See my comment here: #3542 (comment) .

Thanks!

devtools/common/src/main/filtered/extensions.json

devtools/common/src/main/java/io/quarkus/generators/SourceType.java

miteshaghera · 2019-08-16T12:36:03Z

I added a couple more comments.

Could you also add a test of project creation? Considering it was broken, we really need one. See my comment here: #3542 (comment) .

Thanks!

I have added a project creation test inCreateProjectMojoIT for scala.

machi1990 · 2019-08-16T12:48:16Z

devtools/maven/src/test/java/io/quarkus/maven/it/DevMojoIT.java

@@ -189,6 +189,34 @@ public void testThatTheApplicationIsReloadedOnKotlinChange() throws MavenInvocat
                .atMost(1, TimeUnit.MINUTES).until(() -> getHttpResponse("/app/hello").contains("carambar"));
    }

+    @Test
+    public void testThatTheApplicationIsReloadedOnScalaChange() throws MavenInvocationException, IOException {


By nature, these tests IT take some minutes to run, I wonder if this test should be a unit test using QuarkusDevModeTest since #3317 has already landed.

@gsmet WDYT?

If QuarkusDevModeTest can cover this case, it would be ideal to use it.
And if it does, then replacing the existing tests with something that uses QuarkusDevModeTest would be even better :)

Sure, I think tests that check if files have been correctly modified, deleted etc can leverage QuarkusDevModeTest. We have an issue for that?

Not that I know of, but I haven't really checked

gsmet · 2019-08-19T11:12:13Z

Merged, thanks! Very nice addition.

gsmet requested changes Aug 12, 2019

View reviewed changes

devtools/common/src/main/filtered/extensions.json Outdated Show resolved Hide resolved

gsmet reviewed Aug 12, 2019

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/builditem/FeatureBuildItem.java Outdated Show resolved Hide resolved

miteshaghera force-pushed the feature/scala branch from 0a82e2d to 9bb6f26 Compare August 13, 2019 17:36

gsmet added this to the 0.21.0 milestone Aug 13, 2019

gsmet requested changes Aug 14, 2019

View reviewed changes

devtools/common/src/main/java/io/quarkus/generators/SourceType.java Outdated Show resolved Hide resolved

devtools/common/src/main/resources/templates/basic-rest/scala/pom-template.ftl Outdated Show resolved Hide resolved

gsmet removed this from the 0.21.0 milestone Aug 14, 2019

miteshaghera force-pushed the feature/scala branch from 9bb6f26 to 35758a5 Compare August 14, 2019 20:28

gsmet added this to the 0.22.0 milestone Aug 15, 2019

gsmet requested changes Aug 16, 2019

View reviewed changes

devtools/common/src/main/filtered/extensions.json Outdated Show resolved Hide resolved

devtools/common/src/main/java/io/quarkus/generators/SourceType.java Outdated Show resolved Hide resolved

miteshaghera force-pushed the feature/scala branch from 35758a5 to 5c32c24 Compare August 16, 2019 12:34

machi1990 requested changes Aug 16, 2019

View reviewed changes

Initial support for scala

dfdb3db

miteshaghera force-pushed the feature/scala branch from 5c32c24 to dfdb3db Compare August 16, 2019 13:11

gsmet approved these changes Aug 19, 2019

View reviewed changes

gsmet merged commit e51ecb9 into quarkusio:master Aug 19, 2019

gwenneg mentioned this pull request Aug 19, 2019

Create Kotlin project fail due to pom.xml-template.ftl #3541

Closed

wiradikusuma mentioned this pull request Aug 24, 2019

Scala language support #1413

Closed

gsmet added the release/noteworthy-feature label Sep 26, 2019

miteshaghera deleted the feature/scala branch April 3, 2021 13:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scala language support #3399

Scala language support #3399

miteshaghera commented Aug 1, 2019

gsmet commented Aug 1, 2019 •

edited

miteshaghera commented Aug 5, 2019 •

edited

gsmet left a comment

gsmet left a comment

miteshaghera commented Aug 14, 2019

gsmet left a comment

miteshaghera commented Aug 16, 2019 •

edited

machi1990 Aug 16, 2019

geoand Aug 18, 2019

machi1990 Aug 18, 2019

geoand Aug 18, 2019

gsmet commented Aug 19, 2019

Scala language support #3399

Scala language support #3399

Conversation

miteshaghera commented Aug 1, 2019

gsmet commented Aug 1, 2019 • edited

miteshaghera commented Aug 5, 2019 • edited

gsmet left a comment

Choose a reason for hiding this comment

gsmet left a comment

Choose a reason for hiding this comment

miteshaghera commented Aug 14, 2019

gsmet left a comment

Choose a reason for hiding this comment

miteshaghera commented Aug 16, 2019 • edited

machi1990 Aug 16, 2019

Choose a reason for hiding this comment

geoand Aug 18, 2019

Choose a reason for hiding this comment

machi1990 Aug 18, 2019

Choose a reason for hiding this comment

geoand Aug 18, 2019

Choose a reason for hiding this comment

gsmet commented Aug 19, 2019

gsmet commented Aug 1, 2019 •

edited

miteshaghera commented Aug 5, 2019 •

edited

miteshaghera commented Aug 16, 2019 •

edited