Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix endpoint address in the OpenShift guide #34041

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix endpoint address in the OpenShift guide #34041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63cbde
Fix endpoint address in the OpenShift guide
sberyozkin Jun 14, 2023
b260484
Minor adjustments to deploying-to-openshift.adoc
gsmet Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/src/main/asciidoc/deploying-to-openshift.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,14 @@
----
oc expose svc/greeting <1>
oc get routes <2>
curl http://<route>/greeting <3>
curl http://<route>/hello <3>
----
<1> Expose the service.
<2> Get the list of exposed routes.
<3> Access your application.

[[control_application_config]]
=== Configure the OpenShift Application Manually
=== Configure the OpenShift Application Manually

Check warning on line 127 in docs/src/main/asciidoc/deploying-to-openshift.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Headings] Use sentence-style capitalization in 'Configure the OpenShift Application Manually'.

Raw Output:
{"message": "[Quarkus.Headings] Use sentence-style capitalization in 'Configure the OpenShift Application Manually'.", "location": {"path": "docs/src/main/asciidoc/deploying-to-openshift.adoc", "range": {"start": {"line": 127, "column": 5}}}, "severity": "INFO"}

If you need more control over the deployment configuration you can build the container image first and then configure the OpenShift application manually.

Expand All @@ -147,7 +147,7 @@
quarkus.kubernetes-client.trust-certs=true
----

For more information, see link:https://quarkus.io/guides/deploying-to-kubernetes#client-connection-configuration[deploying to kubernetes].
For more information, see link:https://quarkus.io/guides/deploying-to-kubernetes#client-connection-configuration[deploying to Kubernetes].
====

Once the build is done we can create a new application from the relevant `ImageStream`.
Expand All @@ -159,9 +159,9 @@
oc get svc
oc expose svc/greeting <3>
oc get routes <4>
curl http://<route>/greeting <5>
curl http://<route>/hello <5>
----
<1> Lists the image streams created. The image stream of our application should be tagged as <project>/openshift-quickstart:1.0.0-SNAPSHOT.

Check warning on line 164 in docs/src/main/asciidoc/deploying-to-openshift.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.TermsWarnings] Consider using 'OpenShift' rather than 'openshift' unless updating existing content that uses it.

Raw Output:
{"message": "[Quarkus.TermsWarnings] Consider using 'OpenShift' rather than 'openshift' unless updating existing content that uses it.", "location": {"path": "docs/src/main/asciidoc/deploying-to-openshift.adoc", "range": {"start": {"line": 164, "column": 104}}}, "severity": "WARNING"}
<2> Create a new application from the image source.
<3> Expose the service to the outside world.
<4> Get the list of exposed routes.
Expand All @@ -177,9 +177,9 @@
- xref:container-image.adoc#docker[container-image-docker]
- xref:container-image.adoc#jib[container-image-jib]

When a non-s2i container image extension is used, an `ImageStream` is created that is pointing to an external `dockerImageRepository`. The image is built and pushed to the registry and the `ImageStream` populates the tags that are available in the `dockerImageRepository`.
When a non-s2i container image extension is used, an `ImageStream` is created that is pointing to an external `dockerImageRepository`. The image is built and pushed to the registry and the `ImageStream` populates the tags that are available in the `dockerImageRepository`.

To select which extension will be used for building the image:

Check warning on line 182 in docs/src/main/asciidoc/deploying-to-openshift.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.TermsSuggestions] Depending on the context, consider using ', which (non restrictive clause preceded by a comma)' or 'that (restrictive clause without a comma)' rather than 'which'.

Raw Output:
{"message": "[Quarkus.TermsSuggestions] Depending on the context, consider using ', which (non restrictive clause preceded by a comma)' or 'that (restrictive clause without a comma)' rather than 'which'.", "location": {"path": "docs/src/main/asciidoc/deploying-to-openshift.adoc", "range": {"start": {"line": 182, "column": 10}}}, "severity": "INFO"}

[source,properties]
----
Expand Down