Replaced deprecated Config phase BOOTSTRAP in Kubernetes

[radcortez]

No description provided.

[geoand]

@radcortez any chance you break up the change to the kubernete-client and kubernetes-config modules into separate commits?

[radcortez]

Separate commits in the same PR you mean? Or do you prefer to have separate PRs?

[geoand]

Same PR is fine

[radcortez]

Ok, let me see what I can do.

[geoand]

Sorry for nitpicking, but could you fix the description of the commit for the kubernetes-client, as the commit just changes to ConfigMapping (the is no Bootstrap phase for the kubernetes-client) extension.

[geoand]

Also cc, @metacosm as this might break the JOSDK

[radcortez]

Sorry for nitpicking, but could you fix the description of the commit for the kubernetes-client, as the commit just changes to ConfigMapping (the is no Bootstrap phase for the kubernetes-client) extension.

Sure. No worries.

[quarkus-bot]

Failing Jobs - Building 6f6fb9e

Status	Name	Step	Failures	Logs	Raw logs
✔️	Gradle Tests - JDK 11
✖	Gradle Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.1.1-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 100 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.1.1-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

[metacosm]

Can I get a TL,DR; description of what this does and what purpose this serves, as well to how things are potentially affected downstream, please?

[geoand]

What you care about is that KubernetesClientBuildConfig and KubernetesDevServicesBuildTimeConfig are now interfaces

[metacosm]

Ok, where could I learn more about why this change was made? In particular, is it something that people are now expected to do in their own extensions (as opposed to having public fields on config classes)?

[geoand]

Ok, where could I learn more about why this change was made?

@radcortez ^

In particular, is it something that people are now expected to do in their own extensions (as opposed to having public fields on config classes)?

Yes, but there is no rush.

[radcortez]

Ok, where could I learn more about why this change was made?

Certainly. Here is something that I wrote about the Class vs Interface approach:
jakartaee/config#122

Also, there are some additional reasons for Quarkus:

• The old class / ConfigRoot approach works exclusively for Quarkus extensions, meaning that application developers had to use a different mechanism. The new interface approach works for both extensions and applications
• The old mechanism was built around the Config system, which complicated a few things (for instance, the config classes would only be available at a certain point in the runtime). The new system is built inside the Config system, so they are immediately available once Config is up.

[metacosm]

Thanks for the info, @radcortez!