Explain why quarkus-smallrye-jwt may need to run in blocking mode #34575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Jul 6, 2023
geoand
reviewed
Jul 6, 2023
sberyozkin
force-pushed
the
jwt_doc_updates
branch
from
7ad7121
to
c75700d
Compare
sberyozkin
commented
Jul 6, 2023
|
|
||
| In such cases, if the connections are slow, for example, it may take more than 3 seconds to get a response from the key endpoint, the current event loop thread will most likely block. | ||
|
|
||
| To prevent it, set `quarkus.smallrye-jwt.blocking-authentication=true`. |
There was a problem hiding this comment.
@AdamBien FYI - it may not be necessary, please check. Quarkus is super fast either way, but smallrye-jwt-reactive is on the map, just not sure yet when it will happen, but it will eventually
There was a problem hiding this comment.
I think the key retrieval / resolution could be too slow / cause the timeout:
(vertx-blocked-thread-checker) Thread Thread[vert.x-eventloop-thread-0,5,main] has been blocked for 2557 ms, time limit is 2000 ms: io.vertx.core.VertxException: Thread blocked
at java.base@17.0.6/java.lang.Thread.sleep(Native Method)
at org.jose4j.http.Get.get(Get.java:111)
at io.smallrye.jwt.auth.principal.AwsAlbKeyResolver.retrieveKey(AwsAlbKeyResolver.java:62)
at io.smallrye.jwt.auth.principal.AwsAlbKeyResolver.resolveKey(AwsAlbKeyResolver.java:49)
at org.jose4j.jwt.consumer.JwtConsumer.processContext(JwtConsumer.java:213)
at org.jose4j.jwt.consumer.JwtConsumer.process(JwtConsumer.java:426)
at io.smallrye.jwt.auth.principal.DefaultJWTTokenParser.parseClaims(DefaultJWTTokenParser.java:157)
at io.smallrye.jwt.auth.principal.DefaultJWTTokenParser.parse(DefaultJWTTokenParser.java:60)
at io.smallrye.jwt.auth.principal.DefaultJWTCallerPrincipalFactory.parse(DefaultJWTCallerPrincipalFactory.java:31)
at io.smallrye.jwt.auth.principal.DefaultJWTParser.parse(DefaultJWTParser.java:71)
at io.smallrye.jwt.auth.principal.DefaultJWTParser_ClientProxy.parse(Unknown Source)
at io.quarkus.smallrye.jwt.runtime.auth.MpJwtValidator.createSecurityIdentity(MpJwtValidator.java:76)
The configuration:
quarkus.smallrye-jwt.blocking-authentication=true
solved the problem.
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWT doc updates (sub section about the blocking calls, new properties, minor fixes), follow up to #34564