Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape property name and values when dumping app config #35506

Merged
merged 1 commit into from Aug 24, 2023

Conversation

aloubyansky
Copy link
Member

Discovered by trying to load a config dump with property names containing :. This change makes it compatible with how Properties are persisted to a file.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

Failing Jobs - Building 9d5a925

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20
Native Tests - Security2 Update Docker Client User Agent ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/rest-client-reactive 

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 16 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

@gsmet gsmet merged commit b254b4c into quarkusio:main Aug 24, 2023
45 of 48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 24, 2023
@gsmet gsmet modified the milestones: 3.4 - main, 3.2.5.Final Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants