Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly improve the output of the update command #35534

Merged
merged 1 commit into from Aug 25, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 24, 2023

When having an error, it was extremely confusing, you had confusing error messages, a lot of nested exceptions...

This will improve the output, make sure we have proper colors for the log levels and avoid having two levels logged.
Also avoid a couple of nested exceptions and make the error messages more actionable.

This is slightly related to me fixing #35511 as I noticed a few times that in case of errors, it was relatively hard to find the culprit.

When having an error, it was extremely confusing, you had confusing
error messages, a lot of nested exceptions...

This will improve the output, make sure we have proper colors for the
log levels and avoid having two levels logged.
Also avoid a couple of nested exceptions and make the error messages
more actionable.
@gsmet gsmet requested a review from gastaldi August 24, 2023 13:46
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Aug 24, 2023
@gsmet gsmet added triage/backport-3.2 and removed area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Aug 24, 2023
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one comment

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 24, 2023

Failing Jobs - Building 8150138

| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
| :-: | -- | -- | :-: | :-: | :-: |
| ✖ | JVM Tests - JDK 11 | Build | Failures | Logs | Raw logs |
| ✔️ | JVM Tests - JDK 17 | | | | |
| ✔️ | JVM Tests - JDK 20 | | | | |

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/devmode 

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIHibernateOrmSmokeTest.testGetNumberOfNamedQueries - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

@gsmet gsmet merged commit ce31e4f into quarkusio:main Aug 25, 2023
47 of 48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 25, 2023
@gsmet gsmet modified the milestones: 3.4 - main, 3.2.5.Final Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants