Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register enclosing class for reflection when used as JAX-RS return type #3557

Merged
merged 1 commit into from Aug 20, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 18, 2019

This is needed when a JAX-RS resource returns a parameterized type that
is meant to be an enclosing class

Fixes: #3538

@geoand geoand requested a review from gsmet August 18, 2019 13:48
@geoand
Copy link
Contributor Author

geoand commented Aug 18, 2019

@gsmet This probably isn't the absolute cleanest way to handle this case, but I believe it's in line with what we already have.
One this I am not clear about is whether

addReflectiveHierarchy(i, p.owner(), processedReflectiveHierarchies, unindexedClasses);

should be completely removed because p.owner always seems to be null...

This is needed when a JAX-RS resource returns a parameterized type that
is meant to be an enclosing class

Fixes: quarkusio#3538
@geoand
Copy link
Contributor Author

geoand commented Aug 19, 2019

@gsmet PR updated

@gsmet gsmet merged commit 84ecb95 into quarkusio:master Aug 20, 2019
@gsmet
Copy link
Member

gsmet commented Aug 20, 2019

Merged, thanks!

@gsmet gsmet added this to the 0.22.0 milestone Aug 20, 2019
@geoand
Copy link
Contributor Author

geoand commented Aug 20, 2019

Sure thing!

@geoand geoand deleted the #3538 branch August 20, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-resteasy-jsonb Marshaling Generic Type results in WARNINGS on each request
2 participants