Qute: execute tag templates in isolation by default #35600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
ia3andy
reviewed
Aug 29, 2023
| By default, a tag template cannot reference the data from the parent context. | ||
| Qute executes the tag as an _isolated_ template, i.e. without access to the context of the template that calls the tag. | ||
| However, sometimes it might be useful to change the default behavior and disable the isolation. | ||
| In this case, just add `_isolated=false` to the call site, for example `{#itemDetail item showImage=true _isolated=false /}`. |
There was a problem hiding this comment.
I would use the opposite word: _contextual=true (or any other better word)
There was a problem hiding this comment.
Hm, contextual is IMO too overloaded. isolated was already there but I didn't find a good antonym... In any case, we could add a "positive" alias. Maybe something like _connected or even just _unisolated (note that the =true part is optional)?
ia3andy
approved these changes
Aug 29, 2023
mkouba
force-pushed
the
qute-tag-isolated
branch
from
647b5ca
to
6d744f5
Compare
mkouba
force-pushed
the
qute-tag-isolated
branch
from
6d744f5
to
5ae4d25
Compare
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follows-up of #22003.