Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how PasswordProvider in security-jpa has to be used #35682

Merged
merged 1 commit into from Sep 4, 2023

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Sep 1, 2023

Fixes #35671.

Steph, I did not add any description of supported algorithms - my understanding it is an open ended list because Password provides AlgorithmParameterSpec so even custom hashing algorithms, as long as the corresponding providers are registered with Java Security, will be supported

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably you should also make this clearer in the guide, no?

@quarkus-bot

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Sep 1, 2023
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Sep 1, 2023
@sberyozkin
Copy link
Member Author

@FroMage

Probably you should also make this clearer in the guide, no?

Sure, have a look please how it looks now

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

Quarkus Documentation automation moved this from To do to Reviewer approved Sep 4, 2023
@FroMage FroMage merged commit f3d8f88 into quarkusio:main Sep 4, 2023
22 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Sep 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Sep 4, 2023
@sberyozkin sberyozkin deleted the security_jpa_password_provider branch September 4, 2023 11:40
@gsmet gsmet modified the milestones: 3.4 - main, 3.3.2 Sep 4, 2023
@aloubyansky aloubyansky modified the milestones: 3.3.2, 3.2.8.Final Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

security-jpa: Wrong password passed to custom password provider
4 participants