Remove invalid imagePushSecret from BuildConfig when using internal registry

[iocanel]

Resolves: #35647

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[danieloh30]

@geoand This fix seems to have been added to the 3.4.0 or later version.

1. When will 3.4.0 be released (roughly)?
2. Any workaround to avoid this issue until the fix is added?

[geoand]

@danieloh30 this will be backported to the next 3.3 release as well as being part of 3.4.0.CR1

[danieloh30]

sounds cool! thx for a quick answer @geoand

[geoand]

🙏🏼

[iocanel]

@danieloh30: a workaround would be to create an empty image push secret. Haven't tried it, but it should possibly work.

[iocanel]

An alternative workaround I tried is to remove the registry completely, set an empty image group (so that the image is a single segment image) and rely on the fact that the ImageStreams use local lookup policy.

While this works ok for Deployment it does not seem to work for Knative Service. It's not clear to me why.
Feedback from Openshift or Knative people would possibly help. @maxandersen @rhuss?

[danieloh30]

That's really helpful and good to know!

[rhuss]

While not being able to fully dive into this issue, I can nevertheless that
Knative does not work well with ImageStream because a KService is not an intrinsic OpenShift object that the build controller is aware of. E.g. there can be no redeployment triggered after a new build: https://issues.redhat.com/browse/BUILD-100

Not sure if this helpful in this context though :-)

[danieloh30]

Good to know @rhuss I'd better wait for the next release for this :)