Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable native heap dump monitoring by default #35736

Merged
merged 1 commit into from Sep 12, 2023

Conversation

galderz
Copy link
Member

@galderz galderz commented Sep 5, 2023

Closes #35729

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as start-up times and binary size are indeed minimally affected.

Have you tried passing heapdump explicitly through quarkus.native.monitoring? Is it okay to be added twice in the command line?

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 5, 2023

Failing Jobs - Building 8eceb71

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.SimpleContextPropagationTest.testArcTCContextPropagationDisabled line 92 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@galderz
Copy link
Member Author

galderz commented Sep 12, 2023

Have you tried passing heapdump explicitly through quarkus.native.monitoring? Is it okay to be added twice in the command line?

It is fine. The distinct() stream call makes sure that we don't add the same monitoring option twice.

@gsmet gsmet merged commit e724332 into quarkusio:main Sep 12, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 12, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 12, 2023
@gsmet
Copy link
Member

gsmet commented Sep 12, 2023

I agree it looks like a better default if it doesn't cost us much.

@galderz galderz deleted the topic.0905.enable-heapdump branch December 19, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable native heap dump monitoring by default
3 participants