Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it more obvious in CONTRIBUTING.md that native-tests.json needs to be updated #35838

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Make it more obvious in CONTRIBUTING.md that native-tests.json needs to be updated #35838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ Be sure to test your pull request in:
1. Java mode
2. Native mode

Also, make sure that any native tests you add will actually get executed on CI.
In the interest of speeding up CI, the native build job `native-tests` have been split into multiple categories which
are run in parallel. This means that each new integration test module needs to be configured explicitly
in [`native-tests.json`](.github/native-tests.json) to have its integration tests run in native mode.

## Setup

If you have not done so on this machine, you need to:
Expand Down Expand Up @@ -752,7 +757,7 @@ This project is an open source project, please act responsibly, be nice, polite
* The native integration test for my extension didn't run in the CI

In the interest of speeding up CI, the native build job `native-tests` have been split into multiple categories which
are run in parallel. This means that each new extension needs to be configured explicitly
are run in parallel. This means that each new integration test module needs to be configured explicitly
in [`native-tests.json`](.github/native-tests.json) to have its integration tests run in native mode.

* Build aborts complaining about missing (or superfluous) `minimal *-deployment dependencies`
Expand Down